From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753867AbcCRIni (ORCPT ); Fri, 18 Mar 2016 04:43:38 -0400 Received: from mga02.intel.com ([134.134.136.20]:8349 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750874AbcCRInZ (ORCPT ); Fri, 18 Mar 2016 04:43:25 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,354,1455004800"; d="scan'208";a="671768886" Subject: Re: [PATCH v5 6/6] mfd: intel_vuport: Add Intel virtual USB port MFD Driver To: Lee Jones References: <1458282743-16382-1-git-send-email-baolu.lu@linux.intel.com> <1458282743-16382-7-git-send-email-baolu.lu@linux.intel.com> <20160318080924.GD13692@x1> Cc: Felipe Balbi , Mathias Nyman , Greg Kroah-Hartman , Heikki Krogerus , MyungJoo Ham , Chanwoo Choi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Fengguang Wu From: Lu Baolu Message-ID: <56EBBFA9.30101@linux.intel.com> Date: Fri, 18 Mar 2016 16:43:21 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160318080924.GD13692@x1> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/18/2016 04:09 PM, Lee Jones wrote: > On Fri, 18 Mar 2016, Lu Baolu wrote: > >> Some Intel platforms have an USB port mux controlled by GPIOs. >> There's a single ACPI platform device that provides both USB ID >> extcon device and a USB port mux device. This MFD driver will >> split the 2 devices for their respective drivers. >> >> Signed-off-by: Lu Baolu >> Suggested-by: David Cohen > This should be at the top. > > You couldn't have written the patch before it was suggested. Yes. I will change this. > >> Reviewed-by: Felipe Balbi >> Signed-off-by: Fengguang Wu > What is this sign-off meant to indicate? Fengguang's sign-off was added due to folding a patch contributed by his kbuild robot. https://lkml.org/lkml/2016/3/3/118 I will add this in commit message. > >> Reviewed-by: Lee Jones > Why is this here? > > a) I don't provide "Reviewed-by:" tags #alarmbells > b) I have never signed this patch off Sorry about this. I will remove this line. > >> --- >> MAINTAINERS | 6 ++++ > Seperate patch. If I make it in a separate patch, checkpatch.pl will give me below warning. " WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 " Is it forgivable? Best regards, Baolu > >> drivers/mfd/Kconfig | 8 +++++ >> drivers/mfd/Makefile | 1 + >> drivers/mfd/intel-vuport.c | 74 ++++++++++++++++++++++++++++++++++++++++++++++ >> 4 files changed, 89 insertions(+) >> create mode 100644 drivers/mfd/intel-vuport.c > [...] >