From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Chanwoo Choi <cw00.choi@samsung.com>, linux-kernel@vger.kernel.org
Cc: Lee Jones <lee.jones@linaro.org>
Subject: Re: [RFC/RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a module
Date: Fri, 18 Mar 2016 07:50:32 -0300 [thread overview]
Message-ID: <56EBDD78.7050104@osg.samsung.com> (raw)
In-Reply-To: <56EBB46B.9000503@samsung.com>
Hello Chanwoo,
On 03/18/2016 04:55 AM, Chanwoo Choi wrote:
> Hello Javier,
>
> On 2016년 03월 18일 03:02, Javier Martinez Canillas wrote:
>> Hello Chanwoo
>>
>> On 03/17/2016 01:57 PM, Javier Martinez Canillas wrote:
>>
>> [snip]
>>
>>>>
>>>
>>> Sorry again, this error goes away after I clean the build directory so it
>>> does not happen without this patch-set. Now, I found what's the issue and
>>> is that both the max14577 MFD and regulator drivers have the same object
>>> file name so they both end being called max14577.ko.
>>>
>>> This confuses Kbuild and so in the modpost step, the exported symbols by
>>> the MFD driver don't end into Module.symvers. This doesn't happen when
>>> the driver is not a module since symbols come from the vmlinux binary.
>>>
>>> I'll post a patch to rename the regulator driver to max14577-regulator,
>>> this will be necessary anyways to have max14577 as a module since Kbuild
>>> also gets confused and don't copy both modules because have the same name.
>>>
>>
>> Patch is [0], could you please test the patch-series along with that one
>> and provide your Tested-by? I plan to re-send this series once [0] lands.
>
> I'll test it on next week and then reply.
>
Perfect, thanks a lot for your help!
> Best Regards,
> Chanwoo Choi
>
>>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2016-03-18 10:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 16:48 [RFC/RFT PATCH 0/2] mfd: max14577: Allow the driver to be built as a module Javier Martinez Canillas
2016-03-16 16:48 ` [RFC/RFT PATCH 1/2] mfd: max14577: Use module_init() instead of subsys_initcall() Javier Martinez Canillas
2016-03-16 16:48 ` [RFC/RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a module Javier Martinez Canillas
2016-03-17 1:58 ` Chanwoo Choi
2016-03-17 15:37 ` Javier Martinez Canillas
2016-03-17 16:57 ` Javier Martinez Canillas
2016-03-17 18:02 ` Javier Martinez Canillas
2016-03-18 7:55 ` Chanwoo Choi
2016-03-18 10:50 ` Javier Martinez Canillas [this message]
2016-03-17 1:09 ` [RFC/RFT PATCH 0/2] mfd: max14577: Allow the " Krzysztof Kozlowski
2016-03-17 15:22 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EBDD78.7050104@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=cw00.choi@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox