From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757113AbcCRKuu (ORCPT ); Fri, 18 Mar 2016 06:50:50 -0400 Received: from lists.s-osg.org ([54.187.51.154]:54422 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751816AbcCRKul (ORCPT ); Fri, 18 Mar 2016 06:50:41 -0400 Subject: Re: [RFC/RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a module To: Chanwoo Choi , linux-kernel@vger.kernel.org References: <1458146930-2723-1-git-send-email-javier@osg.samsung.com> <1458146930-2723-3-git-send-email-javier@osg.samsung.com> <56EA0F59.4090507@samsung.com> <56EACF40.8090609@osg.samsung.com> <56EAE1E4.10202@osg.samsung.com> <56EAF128.8050709@osg.samsung.com> <56EBB46B.9000503@samsung.com> Cc: Lee Jones From: Javier Martinez Canillas Message-ID: <56EBDD78.7050104@osg.samsung.com> Date: Fri, 18 Mar 2016 07:50:32 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56EBB46B.9000503@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Chanwoo, On 03/18/2016 04:55 AM, Chanwoo Choi wrote: > Hello Javier, > > On 2016년 03월 18일 03:02, Javier Martinez Canillas wrote: >> Hello Chanwoo >> >> On 03/17/2016 01:57 PM, Javier Martinez Canillas wrote: >> >> [snip] >> >>>> >>> >>> Sorry again, this error goes away after I clean the build directory so it >>> does not happen without this patch-set. Now, I found what's the issue and >>> is that both the max14577 MFD and regulator drivers have the same object >>> file name so they both end being called max14577.ko. >>> >>> This confuses Kbuild and so in the modpost step, the exported symbols by >>> the MFD driver don't end into Module.symvers. This doesn't happen when >>> the driver is not a module since symbols come from the vmlinux binary. >>> >>> I'll post a patch to rename the regulator driver to max14577-regulator, >>> this will be necessary anyways to have max14577 as a module since Kbuild >>> also gets confused and don't copy both modules because have the same name. >>> >> >> Patch is [0], could you please test the patch-series along with that one >> and provide your Tested-by? I plan to re-send this series once [0] lands. > > I'll test it on next week and then reply. > Perfect, thanks a lot for your help! > Best Regards, > Chanwoo Choi > >> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America