From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752251AbcCRL6T (ORCPT ); Fri, 18 Mar 2016 07:58:19 -0400 Received: from lists.s-osg.org ([54.187.51.154]:54455 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752011AbcCRL6F (ORCPT ); Fri, 18 Mar 2016 07:58:05 -0400 Subject: Re: [PATCH v3] rtc: s3c: Don't print an error on probe deferral To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org References: <1458005918-7893-1-git-send-email-javier@osg.samsung.com> <56E76A57.7070104@samsung.com> <56E76C6F.5020803@osg.samsung.com> <56E772F2.2030507@samsung.com> <56E77A6A.2090604@osg.samsung.com> Cc: Joe Perches , Alexandre Belloni , linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com From: Javier Martinez Canillas Message-ID: <56EBED45.6070000@osg.samsung.com> Date: Fri, 18 Mar 2016 08:57:57 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56E77A6A.2090604@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof and Alexandre, On 03/14/2016 11:58 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 03/14/2016 11:26 PM, Krzysztof Kozlowski wrote: >> On 15.03.2016 10:59, Javier Martinez Canillas wrote: >>>>> >>>>> if (info->data->needs_src_clk) { >>>>> info->rtc_src_clk = devm_clk_get(&pdev->dev, "rtc_src"); >>>>> if (IS_ERR(info->rtc_src_clk)) { >>>>> - dev_err(&pdev->dev, >>>>> - "failed to find rtc source clock\n"); >>>>> + ret = PTR_ERR(info->rtc_src_clk); >>>>> + if (ret != -EPROBE_DEFER) >>>>> + dev_err(&pdev->dev, >>>>> + "failed to find rtc source clock\n"); >>>>> + else >>>>> + dev_dbg(&pdev->dev, >>>>> + "probe deferred due to missing rtc src clk\n"); >>>>> clk_disable_unprepare(info->rtc_clk); >>>>> - return PTR_ERR(info->rtc_src_clk); >>>>> + return ret; >>>>> } >>>>> clk_prepare_enable(info->rtc_src_clk); >>>>> } >>>>> >>>> >>>> The error path starts looking complicated. This has now 4 indentation >>>> levels... >>>> >>> >>> Yeah, I don't think we can get rid of the 4 indentation levels since >>> the function already has 3 and a check for the errno code is needed. >> >> Probably handling of the clocks in the driver could be simplified a >> little bit (the if(needs_src_clk) appears in few places)... but this is >> out of scope for this patch. >> > > Agreed, I meant without introducing an unrelated change. > >>> >>>> I agree for removal of error in case of probe deferral because it might >>>> be misleading but I don't see much benefit of a debug message. >>>> >>> >>> But yes, we can at least get rid of the else statement. I don't have a >>> strong opinion about the debug information, I left it to avoid someone >>> to tell me that I was removing a useful log. >> >> Although dev_dbg doesn't harm... but isn't driver core printing debug >> message already? >> > > I don't think it does or at least I didn't find it when looking > at the devm_clk_get() call chain. > >> BR, >> Krzysztof >> Just to make sure that I understood correctly, there's no action I should take in order for this patch to be picked right? IOW, the current version is OK? Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America