From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932884AbcCRN4S (ORCPT ); Fri, 18 Mar 2016 09:56:18 -0400 Received: from lists.s-osg.org ([54.187.51.154]:54503 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754971AbcCRN4Q (ORCPT ); Fri, 18 Mar 2016 09:56:16 -0400 Subject: Re: [rtc-linux] Re: [PATCH v3] rtc: s3c: Don't print an error on probe deferral To: Krzysztof Kozlowski , rtc-linux@googlegroups.com References: <1458005918-7893-1-git-send-email-javier@osg.samsung.com> <56E76A57.7070104@samsung.com> <56E76C6F.5020803@osg.samsung.com> <56E772F2.2030507@samsung.com> <56E77A6A.2090604@osg.samsung.com> <56EBED45.6070000@osg.samsung.com> <20160318120717.GD2531@piout.net> Cc: linux-kernel@vger.kernel.org, Joe Perches , linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski From: Javier Martinez Canillas Message-ID: <56EC08F8.2080400@osg.samsung.com> Date: Fri, 18 Mar 2016 10:56:08 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, On 03/18/2016 09:20 AM, Krzysztof Kozlowski wrote: > On Fri, Mar 18, 2016 at 9:07 PM, Alexandre Belloni >> On 18/03/2016 at 08:57:57 -0300, Javier Martinez Canillas wrote : [snip] >>> >>> Just to make sure that I understood correctly, there's no action I >>> should take in order for this patch to be picked right? IOW, the >>> current version is OK? >>> >> >> I was kind of waiting an answer on the question whether the core already >> prints a message when probe dereferral happens because in that case, >> there is no need for a debug message and we can indeed simplify the >> whole block. > > Although I did not test it, I think the core will print generic defer > message. See really_probe() around line 400: > http://lxr.free-electrons.com/source/drivers/base/dd.c?v=4.4#L347 > > However the cause of deferring will not be printed... so I find some > use of debug message in driver... On the other hand, not many drivers > are doing this. Ehh, I guess I am just really picky. :) > It's Ok, I also have doubts about which direction to take even when writing trivial patches like $SUBJECT, so I understand the feeling :) > BR, > Krzysztof > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America