From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932510AbcCRSkJ (ORCPT ); Fri, 18 Mar 2016 14:40:09 -0400 Received: from mail-bn1bon0072.outbound.protection.outlook.com ([157.56.111.72]:48342 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756545AbcCRSkF (ORCPT ); Fri, 18 Mar 2016 14:40:05 -0400 X-Greylist: delayed 165038 seconds by postgrey-1.27 at vger.kernel.org; Fri, 18 Mar 2016 14:40:04 EDT Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=amd.com; arndb.de; dkim=none (message not signed) header.d=none;arndb.de; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0O48ZUK-08-9L4-02 X-M-MSG: Subject: Re: [PATCH v2] ata: add AMD Seattle platform driver To: Arnd Bergmann , Tejun Heo References: <1452789071-4090-1-git-send-email-brijesh.singh@amd.com> <5709817.yQT8N3CaLj@wuerfel> <20160316210713.GI21104@mtj.duckdns.org> <31951835.kMFH9CgruZ@wuerfel> CC: , , , , Graeme Gregory From: Brijesh Singh Message-ID: <56EC4AB8.7040901@amd.com> Date: Fri, 18 Mar 2016 13:36:40 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <31951835.kMFH9CgruZ@wuerfel> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.222;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(377454003)(24454002)(189002)(199003)(5008740100001)(86362001)(76176999)(23746002)(54356999)(64126003)(50466002)(189998001)(77096005)(50986999)(230700001)(101416001)(59896002)(5001770100001)(81166005)(87936001)(92566002)(36756003)(5004730100002)(4001350100001)(1096002)(65956001)(586003)(11100500001)(6116002)(1220700001)(83506001)(106466001)(105586002)(65806001)(33656002)(4326007)(93886004)(2950100001)(2906002)(47776003)(3846002);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR12MB0709;H:atltwp02.amd.com;FPR:;SPF:None;MLV:sfv;MX:1;A:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: 9f88dd0c-1eab-413e-839e-08d34f5cb711 X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0709;2:Iw/dmBhwtdWXzMOGxsaIHDLm9b8m0yQQ/nikML58qEUSfwgqiL8HWxY9QJSPHR2buwDun6h0xoGUZjfMmSDzuEwv4YdiPGvvawR/7DHDZtZVwhdjDhL0M6d7g+1DyIONZG+cnB5vQNyxiFphagPpVOatS5cAKXiYjZ/35SzCT2JmgiG/o3xp+4Xw0SSe2SQ8;3:KuYJ1AA1QYhZuL+5aPECrTEMcruY9AAxRxb+h7rDgXHW3hRkE8GoNv95CFNo9u/+QgIVTu9Vp7J8Gg5x+caGEbb+yy1oMyVe7Mftk22tPG0HBmSZLmB1MkZj9bJRV7K1m20KLAAwpUOH9BJgMttcj9iRHN67BH6jmhRpKo8lpX5qOr/f6oI7dZLIaDIAAael95O++HAkJyAfOs9jf4khfax16KjPwlBqMALc/gWMOUI=;25:zFFDHUT4Gh8kUEjkbhaNuJQE7N9+ZHXr2ropdY/Eoy9YhagZASEGtunHxU7rX2w7ebPrFkdQ9IzFgaWcX42tt2pzCr3d6ie54lqOhUsyRufOcYrNC0McwzZgWz35oj8Qo9jgf7z6X+vWobL2u6esVu6CuLEgavsbIDOyiEd2wbWAHjWDO70NKyrn+UckvxygK+D3qJCba1+2E+bchpS4RQ+hDuo1z1RFpVgHsz7LwNWABToybXdIectDGd6UbKm7nEcM6gwCvtt9Pyg41xdvpZVlyVI2AyyuQDrt+2Zo/z8ljeHyaT23gCVRlmYTm9mFWr1w4WoO3Dfo9SZ55H0ds+UKALda90kbEzy1o1XSMJ+JEBcY4ylIhheQMjsok+qqS37fMLcqp/Fk2PKkuS7tWSgpU1iNswn6D8XPZrjuw4JGDPb+daTsZEAnxZOM9JaAlLVxjRTdrexrRloA0zIl8SmbgXRoNMBgivLCUn+izd9k6vJycSS4WU7ylZW7xLLS X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR12MB0709; X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0709;20:/3+Uw0A0NaT+aQSMeDltWusivetfKDfkZLvk5XjHpm53boL0sO93AfudrWo8l68h3qU7sSyzpihqVzrdodbvAIsC5tQZSM4iDhWe/pg2tx/40GYMoKdRyqzyCfgv1c1rkptuzIfBEHaWSBv6dz/OQGm+R/QpJgFL4aNo4F3aZtxMb8Laf73OUcvrtRxjyVewwZOLSpA/hLkXZHh4unOt32WL+S5dnGae/LeuvBiYl7PUmdIvTXrGAL1jFJ0lRXtQdtsSlMIbz8eh7w6E2MTZv00yxaHUHRbGkmVpZbFmY8/v/t+m4hPZR/8ovQG+fcWcDaesp89jft5fd8NfM4HVy8qwvzfzq9J3IfPKQW3mnxLg+1sAlEkTcgV6FbXoCSCCmF9cUsLFlpFtUu3DasqFsh6PO645TF2sryxTDzsphhTmWXZOIjr6R0eLjPCSo97VmUU5rIsmTH1kOg78ObVAncaFEBlGNj+1tj3bnCgeDcvKSXrbhrReWoo2bRwJMe15 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13015025)(13018025)(13024025)(13023025)(13017025)(5005006)(8121501046)(3002001)(10201501046);SRVR:BY2PR12MB0709;BCL:0;PCL:0;RULEID:;SRVR:BY2PR12MB0709; X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0709;4:o8zlCxeiYZPPUdh8fEZni4KoDWo9EaT6oxWDCvQpvh3U4hYzOZWyIvy9w1/Lf2ikHLZkG4bIxA2fNLEsJQXhu8dqY0Rk66epymWDYI+xPBkrXEIBIYbsbHvXkQTC0JMAtNntPtVvasvLljNOf5K75FoHuJAS/etKO5hvkRdrc+tZPvx9NEmMmpEgKHZESrR1pZ2mD989Kkycz27yNfyF5F2mmajjbWWDmaWQrUsRIgb6qe3aaOOsZtw6M2qix6wYAKJkOhqyvDAIO+3IV4Qxt/k2+wUCpYieEfCvt5D6Wi04ZCpHQ/ajC724MyMBcpA1lb/I0ikv0BRk7JSGT54uvfQcnq0DkwGM1K7DycnyROBucvFL9ud7fFSS0oVY00ZBVnAdTcE93XW2f4QvUeT12OapNNmtoynuDB772crYv8rTFWjd8TaUnlK3AD9fzrFU3ckQX5uWgm1Os+twRLCq0Q== X-Forefront-PRVS: 088552DE73 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BY2PR12MB0709;23:VJZ8GuPmN4GoXYC9V0KmZkFXbu7JdTgzaKHaU?= =?Windows-1252?Q?lpxMJBNiwojG6dmzn9WfDkpkFvuax9E5Bs6h4Ao+cCRpm7//CdaP4xYg?= =?Windows-1252?Q?9s/CllN3SE4ZyH0jNa96drzwNhvZWNEdSqHT3z3ojeUdItNhaEZGhC3K?= =?Windows-1252?Q?GaUVjFh54UalJqO6lWyfQX1WVS1dw9CIY2kP7jUnYJhxCUMfAXo4VN5V?= =?Windows-1252?Q?vXVynVnE1QbD85gGrVQVpErtjKZ9Y8yJumfvh09Njo5wAPOrmUZe9n24?= =?Windows-1252?Q?NfvdjL7AMlXjy64Ds/JChgtbNs5a+Lfyb7kpCKilHZevIX5E7dXu5jYE?= =?Windows-1252?Q?EgKBa3XdrdviG8qsBYja7ahkrGh+MU8GjQMM8mee1PSsI7i08NawmYxj?= =?Windows-1252?Q?6cMsV7hQH6QyIlRdzB9wTYZddIZDq0bHebwq/MO3plu3phozbbYLdn28?= =?Windows-1252?Q?tY7KGVHmDCZzK/+DyNekiQ7TnhMSkifbynFb3eYXHELuYjPQOr7KBhd5?= =?Windows-1252?Q?+fa3fzLqPaTZJDLNQciFr6TIggGOKODwRaoPUV3ZbkMAcFIXnA3rk0GD?= =?Windows-1252?Q?ru1h7hsWfhDLc1iTjd+nhb93nRvmVsNr8P68zRaoril2uxx92pJbWSkT?= =?Windows-1252?Q?x2RwlcJPAaZ7sHZeh+pniqLRRFuBqSfwT8bqFye92WInD5cap36SmmBD?= =?Windows-1252?Q?Q6I63ejxwGFF/o5flXRv0sSjLzh1w7lNPT6Fl1h5QL37vxmfjw8nsdqO?= =?Windows-1252?Q?i54Lch3jpvKPY4+ZlhzeFiPFRn6Oi/zwe/3McNO2lBtmaktto8/aLL6m?= =?Windows-1252?Q?KV+R6BRMgajgLGX4Cdo2vhdHmBN7EtkI1kB0yNw3HdiBtze7fMCBY2GD?= =?Windows-1252?Q?84vfRcNOPyWRf3ZDn8HRoj1RnPFgMX7d5eOYirrJtlPOjDu0DRBhTnQk?= =?Windows-1252?Q?rzG5CnnMZzp2CXMitZEtFyyK5f6kpPYptkfsVpbz4gdD/LWX4Qk9WCqk?= =?Windows-1252?Q?3FfewS/CGtv0yzdfJo9q1SXQpymrPSUGqxiOoQLW1kAnUANaN5c3rvbM?= =?Windows-1252?Q?nZR4ZMiyErV8Dh45s5f5pKUJ14mFjO4ia2uWG44ejPxMn6zcjv7LcRgQ?= =?Windows-1252?Q?tr8mJqRmzPm54BJYCPD9M2EsmLiG8YhioqCW06EXz6HbdRe0E+OH3uJt?= =?Windows-1252?Q?K8edwDGNT3xDg512dzN2dFP89Pzqdw+gr/7zel0Yc7RAm5lNrUe?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0709;5:vJeR01Wx1myWqHOuyOmwY7n3Vc65u5GEVGTBt4UdLcvI3UeVl7wPvbCno7c8E9Nqr2L6s3mRO4jhKuqbP2lmnyLHCdHx/YEzSEyLvmXdh+Sk07PFRxh7lIWo2FfAqu7FOVSzsmrQ5tHOEkNiG/lPBQ==;24:W2mqPMe264DhDc4BQpShz5tuT501u/L+1EZbP1bPQEUDmiT2ElPcH3aTNzSnsoCvHRoJzqmdGWTQ7pAChSJK354MGsqJaFETHfCnPL2H/Us=;20:VaEbRyJU/bKZMpvNL+coE+fBsw9wHsWlYOsV3cpcQq8xPxFRR3T+Eran5Xkqpn/CIKWxg5N4tbWPcGg8qO2jQdmepAU6vy347jKWcF3+bS2U6XRWOGe2lP9MYyN7M28Y5B+TP8PPqBR2pseLpRfR2AfivdwQa2+ZnqTZf6kAo/jQ76ZerZ0T+yOxiur+84JSoKw8j08WP+t2KdcbEad19JCpXr3QJIu8orgnxFxiWaSPQ83iiSE5H5wtiv284dPS SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2016 18:40:00.8522 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.222];Helo=[atltwp02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR12MB0709 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tejun, On 03/17/2016 12:36 PM, Arnd Bergmann wrote: > On Wednesday 16 March 2016 14:07:13 Tejun Heo wrote: >> Hello, Arnd. >> >> On Mon, Feb 01, 2016 at 09:14:17PM +0100, Arnd Bergmann wrote: >>>> I am not debating on your AML call recommendation, it sounds like >>>> a good idea however BIOS is already released hence its bit late to >>>> add AML methods for this. I am seeking guidance on what can be >>>> done in the given situation. I thought platform driver is one >>>> option to get this feature enabled in kernel. >> >>> This is where we really need the ACPI maintainers to explain the >>> general policy for dealing with firmware updates. >>> >>> I would assume that adding the feature in a later firmware version >>> is a compatible change, and the feature is non-essential (the >>> device will work fine with the generic SATA driver, except >>> the LEDs don't blink), so it's not a big deal, it's just what >>> you get for having the firmware shipped before the driver is >>> reviewed (don't do that). >> >> So, if it were x86, I'd commit the custom driver without thinking too >> much as ata drivers have always been working around bios issues (there >> often wasn't any other recourse). If the hardware is already out >> there and it's not too easy to roll out bios updates, from libata >> side, I'm okay with having a custom driver to work around that. What >> do you think? > > > It's your call in the end. My main objection is to the fact that > I have suggested a clean implementation for the normal DT based > path that also fixes existing platforms that used to work in the > past and were broken by the (long-ago) move from drivers/ide to > drivers/ata, Brijesh has not implemented that but has instead > continued pushing the hack for the ACPI mode that is still > experimental on ARM64. > I am helping a customer who want EM support in a distro (using ACPI mode). Since its difficult to update the bios hence can I request to pull this driver. The driver solves the ACPI usecases. As per DT is concerned, will look into driver/ide and led framework but since I am not very familiar with driver/ide and led framework hence it will take sometime to design and implement the DT cases. > Arnd >