From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754453AbcCSBcs (ORCPT ); Fri, 18 Mar 2016 21:32:48 -0400 Received: from mail-bl2on0055.outbound.protection.outlook.com ([65.55.169.55]:11520 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753243AbcCSBcn (ORCPT ); Fri, 18 Mar 2016 21:32:43 -0400 Authentication-Results: spf=pass (sender IP is 63.163.107.172) smtp.mailfrom=sandisk.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac160a68-6a3ff70000001e92-b5-56eca8a25072 Subject: Re: [patch] ib_srpt: fix a WARN_ON() message To: Dan Carpenter , Doug Ledford References: <20160318054159.GE2111@mwanda> CC: Sean Hefty , Hal Rosenstock , Nicholas Bellinger , "Sagi Grimberg" , Alex Estrin , , , From: Bart Van Assche Message-ID: <56ECA8A0.5060502@sandisk.com> Date: Fri, 18 Mar 2016 18:17:20 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160318054159.GE2111@mwanda> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBIsWRmVeSWpSXmKPExsWyRoxnke6iFW/CDF5PVrC48PQ7k8Xrf9NZ LF6e/8BqsXHzREaLrbekLS7vmsNm8exQL4tF2+ozjBY32h6wWTSv38DiwOWxc9Zddo/Fe14y edzffoTJ49n0w0weH5/eYvF4v+8qm8fnTXIB7FFcNimpOZllqUX6dglcGfdONLIXvGGr+Ddh C2MD4yPWLkYODgkBE4kZ3TZdjFwcQgKbGCV+zJzBDOHsYJS4+G8+excjJ1hRc+8FVojEXEaJ rs9LwRLCAqYS95b+YAOZJCIQJHHzJRdIWEhAS+Lkgm+MIPXMAmuYJObPuMkEkmATMJL49n4m C4jNC1R0Yg+EzSKgKnFg7lEwW1QgQuLJ3JOMEDWCEidnPgGLcwpoSzw8OQvsamYBe4kHW8tA wswC8hLb384BO1pC4CGrxKWZ7SwQR6hLnFwyn2kCo/AsJKNmIbTPQtK+gJF5FaNYbmZOcW56 aoGhoV5xYl5KZnG2XnJ+7iZGcHxxZexg3DrJ/BCjAAejEg9vR9CbMCHWxLLiytxDjBIczEoi vLlzgUK8KYmVValF+fFFpTmpxYcYpTlYlMR5rVvUwoQE0hNLUrNTUwtSi2CyTBycUg2Ma2KW LmXeIGprZD7Xfe4DoZfTJigwdqq6FUaLngs7bxDsNcPxi59LCd9ZwfOu3XNOVUVlNh+60phq brDTo1T8hoZnPuO8q5c3Fzmsk/v/a/2XgPnzdm6sdRcTWKibeDh88ul1j18eZvCaKFLQEqYS dqdY4NlCe907ayMv8+sKiKhHndseEfpYiaU4I9FQi7moOBEAud7jxKsCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupnluLIzCtJLcpLzFFi42Lh2siRortoxZswg+4rAhYXnn5nsnj9bzqL xcvzH1gtNm6eyGix9Za0xeVdc9gsnh3qZbFoW32G0eJG2wM2i+b1G1gcuDx2zrrL7rF4z0sm j/vbjzB5PJt+mMnj49NbLB7v911l8/i8SS6APYrLJiU1J7MstUjfLoEr496JRvaCN2wV/yZs YWxgfMTaxcjJISFgItHcewHMFhKYzSjx8Q0jiC0sYCpxb+kPNhBbRCBI4lzrVnaIGi2Jkwu+ gdUwC6xgklh3qQrEZhMwkvj2fiYLiM0LVHNiD4TNIqAqcWDuUTBbVCBC4snck4wQNYISJ2c+ AYtzCmhLPDw5ixVipq3Enbm7mSFseYntb+cwT2Dkm4WkZRaSsllIyhYwMq9iFMvNzCnOTc8s MDTSK07MS8ksztZLzs/dxAgOcs6oHYzXJ5ofYmTi4JRqYDxge/z0TKYdEoVrtRa1mM6sfDiZ Uep2r59Q+udHfh3J3/tOfzXZ+u/M/5ISM7bHeYtXxT5kTOv4NPNu+i4LqU3yHcn5N6+nev4O zJNUvv3FfE1QWURN983wkkl2m1XOlQkW7l0g/+7iPgbVWp29t9qetThcmLxkyq8NL+8tkHKZ li6WK9K/5LMSS3FGoqEWc1FxIgB0syBgIgIAAA== X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:63.163.107.172;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(199003)(24454002)(189002)(230700001)(83506001)(2950100001)(19580395003)(19580405001)(77096005)(11100500001)(5008740100001)(1096002)(59896002)(1220700001)(586003)(50986999)(23746002)(76176999)(106466001)(87266999)(86362001)(54356999)(15650500001)(92566002)(36756003)(4326007)(2906002)(50466002)(47776003)(4001350100001)(5001770100001)(65806001)(65956001)(189998001)(87936001)(64126003)(33656002)(81166005);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR0201MB1512;H:milsmgep11.sandisk.com;FPR:;SPF:Pass;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD009;1:f0yTt+8jziRL8jvrrEkjP2HUWetVhKBflXbynXaVmEzgWDr4cVrVjgpePNWsoJHWzHBQ1V7Bxm47h9NEO/zqVDAmSq5UAD/njfQLIy8Ay3DsecFLaf0EtmDKq/H33roe90Bpvc3rHx13zHAcBVngsI73jB08jkEFP/fYlhr99j1Y1RFuA4FAelbo4DZ2f132GncF1Dwp3N5RgKExnUjWCy9ktjcRdDRi7ZY370Y3dRM7msMJnDJwM57WMORZCwwMi8zFdVHo72+RR2mkrjhx+WvtPZkzN1io08v1CicNwGB4udmiLI/Z1N6lb8SdqtXj68ka7BQOzp5ROA6HZMD8v0S28kJKefsMOv2FkTzR+X8JiblGR4zZZVjImUt6p8KivuDiMr7i2h9oX6rCxmxdJXpyimhbWTPL4NSAeohGhKENDoz+1685ybqBjfV73hCqEMEp7LHzCoe0VOjdBPwlXR3fyms3jjLjn3ZBcd3/A6R9O/l6qIp9ED91sB7lR/nLdB6BQcOonm6N6hY5DVWvrg== X-MS-Office365-Filtering-Correlation-Id: 004f737d-a7a8-4326-c026-08d34f943c60 X-Microsoft-Exchange-Diagnostics: 1;BY2PR0201MB1512;2:sP4jnYh1H8Ngip7oNiCTDggPqfNg6QXdjJgckWC3wy10KxtHnClBbJo3TTVYky9T92Wer0XezL5gy4hOmE3nMup+m5/AODrJF8IgbxkwYVvzjgwtb1jrW1CV0mx0n4UyPeXHQRinnvUBo2kcN15QexSNcVsJ8k/3JerP3u3ATdPazSUBbmi5/AKXS1jFFyqn;3:g7xI9Rjf7LanjEq1v5SAAjoGceiqN9uQaRohi/62+7GtPC2BBDwlybOAF6xFF3dnYmhusU0JdedCMxsjgV1xx3xpf1/49546L5QVUWiVsC/m706kfNahfzZLnach7aT/t1wMEPq/XKmSOu94Z7BY0NMoYk6yAJJ0TOTHEBUzuiPEb5l5wspa+G7hYYvt7URgvlqp9IfmMWBjle9n9vN70hl0wjLKTjrGvcBPgbJyzGHi9Mn4vfRZTNwMjvjtXBm9xi3PdkCYfzehnLER8BOWjQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:BY2PR0201MB1512; X-Microsoft-Exchange-Diagnostics: 1;BY2PR0201MB1512;25:iCJegbB4fEAu/QJGZzNwqt/DNU+t9B7E2CktgmK+DMWUjLra0DH6nEn3RhxgU7Bze/hZjUmm+jWL0DK5wUlwvsGDsGlT3zUoJ6ZTE/un5cN4qOe3RzdYKc6sgqjee1h/pmSg8FJX4BqJ/1hDJFarljGNiAzb9AfsRcIGqlzrDOAeI3NsfYzACfhfyTYV5XosqgbNw7OXUBGygltSQqpO7Bp3EpCrhoj7r6do+C6ehzAm8AGFCssIBVK0o8BRHNdjiUwvoNGKiwKZvFuOdbGW6iqmBuQC7WZZsWuSDLrKFLnazyElvAPDFm9G88Qyqe2V3urwakMMBo6F1kTk/0ZJEEOjt+KaYwBj/x4WJTNitSaMq0TNoHI6Mo+GBxQUu0ANmM6WSbVdDcyKttNyR0BGXumZ+8ScB/gGynp66d3bStMsCBL/4OAKQ9T4fpqarsdfJQrZ9p8QmgtlBfyaT51qVP+g4LezlIBn078awZQvZ5nuZqndthIAMwOBcp/AxBv8sBetHXhynwLbKk6RSORKNm60dB4h9S+e01ewu6pgnykjy+2wd+gOGez2Ol7fyXPK X-Microsoft-Exchange-Diagnostics: 1;BY2PR0201MB1512;20:rNfoUt9pq+hJGyZNsu/+XdEmxwQTVg98+PoEZhyXAMBge348jLE9cQSD9lIpOvpCdotDvx2LP08rDfm5HUKusBgS6/6Xx9cR5S4dDul9WM10w+XW6DVOH84nwRb3tb8bkM68cpaYEH9tDLVPMKEWFqnS6l7pGG7Yo8rRAsqS0T/BpSTWTuVevg5TITVjrtHWjoxdhun4nJBEFzIa29/OoHwg8h85Iv4o4AiRjIMrVW8hsmNv2mmCmAGvjmmEzHnUdwfSq9RICdAweMZSfUnJ5rVs+dLkHnsS2eG/MirOKSgmK/BBO0qQgK/HDq5N3Q5yLKCHL0zPcoKxG6b6VI66lAB/09GJ4629ThZNU8MZ0ms998HZXL4Y/p4Vygy/tIk9JOETW8mtLlNCkiWYYoLKsT8CDZYFmV11uWOUnCkb7zTuUhixPtjyn+mrRPY60U9dRAAhoJG7R5Z6YxR7cAnGlNU83g81WI+WiSyY3vLzYOiOxz1ge/jlII269aAdl9Jr X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13018025)(8121501046)(13023025)(13024025)(13017025)(5005006)(13015025)(10201501046)(3002001);SRVR:BY2PR0201MB1512;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0201MB1512; X-Microsoft-Exchange-Diagnostics: 1;BY2PR0201MB1512;4:5Wga8byRvu9LYIa61/ezrM+7hafEp6QGOD8Z5OxW9CDRnT5SLIlQ018domCE0URgN+3XU98DnMRk0jrk/6ZrLSqKpUsg5q6nzRMoYRvAQ8ZA8YcmlfnFUgQ7rRVr3RChJyqUuVQQQBIqw2wHBX7zWxiUnfMco7Qwod5jNeNdcMmC707pImshG3Q2qqSnlNnpKtVytvSiY70Ph7d1kRBpl8Fn7ntQx7kJyXK1SJDRNmDah6OomUNI0iB0zvPTRmixZGJRMORX9slqgj1tjXmNDQGAzEAw6Qkkr9xf0+7spyl9z1tvBa1YWoD8OC69A9zUvoEZn20jV4SSHRlnY3FfFNMHYi8mJCx/BZY63UU4eYvPudG7wC2kfdzShaEyYED1C+hJE3VMlA/c2d2QZh++FCn9GZjsHCCGyCN4k2fGa2TOnYH/S4KQHwIIrbX3ZlXCvdTNwCwv99RUU/INzS52lg== X-Forefront-PRVS: 08864C38AC X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BY2PR0201MB1512;23:ex2FxXSm2S5ZPbhx8vXkaG50kqSG1rNG0vU?= =?Windows-1252?Q?ebkFQQtFJ1aGzeUX81neCo0FZSQFWAe+ErZ3bezGvDrHi6GeiV3L7x2r?= =?Windows-1252?Q?BEbiqH+ZcFYqHHNxhSPBCdTAnhHdL1aBc60/O+Eb1DnYa8oX21jjIBmG?= =?Windows-1252?Q?4WNB5sNkgn0PTfz33R6ZGb2n95mv80fRBUNcmBFxzXoXYFmZhtc/LKo7?= =?Windows-1252?Q?v0yxJ9Y6YJJyYCPVIW6qL/JabPbX/30KUEECeUp9ewvyi86yLiVuEMEx?= =?Windows-1252?Q?aA6KZOdSpDibAbE+n0XT0rhTuAD33+q7Eef47R3yqG54AWrF45iWtH4c?= =?Windows-1252?Q?TM/vdQCMWlxHB//+LLejTYz6veRvIBVQCW+xuyZ4E22xcjlOk97q+r6B?= =?Windows-1252?Q?hsGQ1thCHe2EMqsVd+wsspMcic1tfpji1aci0KOHvCUUSnz699UOxHOK?= =?Windows-1252?Q?w+g2A6ZGfAGjlHZeiWiXkXPM7mRB7m6AnB6eIPRWdE+vMG/1M26t000g?= =?Windows-1252?Q?b9KDkF8hSvvu6BXbcz25F5RcZ4q9X+BPLJD/Q/WgXYbMsRg2/kAop0Mf?= =?Windows-1252?Q?LpTU6pDK3n9t2V63DxoeKAPUkZY1XS6FrmolIpl9oRoRFKONjVEAuAq0?= =?Windows-1252?Q?WcAB+RUrK4HkwZKEL4w/B4wbesuAitg+xMmhzkxh6rXI/LRWj9BwJZb3?= =?Windows-1252?Q?BIJWDlgH9UBmenWQKcuyX5TDQmDYFIo5hgFoAp8z93WT+FQnVb6uUd8h?= =?Windows-1252?Q?+DinVolJ844pTMCGju3QGLc5XFdIOPfzrfFyJT1bCCKlMSQYYzknH2u2?= =?Windows-1252?Q?ysquoZ1gl8TW3g/yXC/Kjw6btldxPTLv0hXyu8j6kC2D7YNBGPhmWr+Z?= =?Windows-1252?Q?xMEM9DiRj428X6WBxJ3ToYn/QaB4hxlS6t54A0A9ria8gC/m98pyU/QB?= =?Windows-1252?Q?Nro5xV4QJ//jZbxSJcMJCWggPTBBrUdUr84QpjjXfocp5Z9NtSanywzJ?= =?Windows-1252?Q?djoKBZk58kRK+Se+PPFCRd6iDkvqlD3OwR6W9CtF0gchZbkAAfNOnDq3?= =?Windows-1252?Q?gtbSHhT9vQF4wNHprRJOXYkH/ko3SLlLPtSWhPNtcWlkVDUk8kBauC3D?= =?Windows-1252?Q?9Yhes97s5fv63+VK0XK3b2wjRMnMqmucXp/dUKtI9Eppz?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR0201MB1512;5:HNNhaOtgjlvBg/hJWQlPGj4H9AVfEsGTIpmZ+cYZ6pn89omw+deo4RL+aBzgdb88O3EuSvoWoolZNLCQ0avaD0jeJZQ4YF6pFdMJ04/amjKE+oMrdejnkeISu2oeITVVRXsbSLvOJKpH3tNy7vUZow==;24:9M4EW/lt4/PAR1F+kYfIHYmQSWx3AogXcE2y7Jm1s+DuUK6SkWG+4I13pyoMAwSc2hREBDRNJIoQ+UhtJCdQ2CbHtCZ2vzMuyRd8GoY5x9w=;20:3hVlvSjwHjHYCk8MamVXKAceLC1I4ye/MUzquVH8DKSaEP90v4SkwMCb7r8UWGVlO0cgdqvRUrI2ZMqw7vxXCRRQ0iCtaLX42i6w83mk4Ozp+W8kkZ61eKkR4T05fiGQs2jhVUtjFxjZ3Y8E4vP6Q5JTHW2/cUIWnkUydFEn+D4CaZVwAo4WpxGhTyiO7QXPfUwofg7NoLRBzH3nwoLAWkOJNAiRQ0BCyZ/8UZbaCX9ncK3pX562m1II2saQeGbA SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2016 01:17:23.2263 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.172];Helo=[milsmgep11.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0201MB1512 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/17/16 22:41, Dan Carpenter wrote: > The first argument of WARN_ON() is a condition, so it means the warning > message here will just be the name without the ->qp_num information. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c > index 1d13090..0bd3cb2 100644 > --- a/drivers/infiniband/ulp/srpt/ib_srpt.c > +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c > @@ -839,7 +839,7 @@ static void srpt_zerolength_write_done(struct ib_cq *cq, struct ib_wc *wc) > if (srpt_set_ch_state(ch, CH_DISCONNECTED)) > schedule_work(&ch->release_work); > else > - WARN_ONCE("%s-%d\n", ch->sess_name, ch->qp->qp_num); > + WARN_ONCE(1, "%s-%d\n", ch->sess_name, ch->qp->qp_num); > } > } Reviewed-by: Bart Van Assche