From: Jens Axboe <axboe@kernel.dk>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>,
Xiong Zhou <jencce.kernel@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
Andreas Herrmann <aherrmann@suse.com>
Subject: Re: [PATCH] blk-mq: Use proper cpumask iterator
Date: Sun, 20 Mar 2016 09:33:42 -0600 [thread overview]
Message-ID: <56EEC2D6.5090603@kernel.dk> (raw)
In-Reply-To: <alpine.DEB.2.11.1603191127590.3978@nanos>
On 03/19/2016 04:30 AM, Thomas Gleixner wrote:
> queue_for_each_ctx() iterates over per_cpu variables under the assumption that
> the possible cpu mask cannot have holes. That's wrong as all cpumasks can have
> holes. In case there are holes the iteration ends up accessing uninitialized
> memory and crashing as a result.
>
> Replace the macro by a proper for_each_possible_cpu() loop and drop the unused
> macro blk_ctx_sum() which references queue_for_each_ctx().
Thanks Thomas, applied.
--
Jens Axboe
prev parent reply other threads:[~2016-03-20 15:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-19 10:30 [PATCH] blk-mq: Use proper cpumask iterator Thomas Gleixner
2016-03-20 15:33 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EEC2D6.5090603@kernel.dk \
--to=axboe@kernel.dk \
--cc=aherrmann@suse.com \
--cc=bp@alien8.de \
--cc=jencce.kernel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox