From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755802AbcCUNYY (ORCPT ); Mon, 21 Mar 2016 09:24:24 -0400 Received: from regular2.263xmail.com ([211.157.152.3]:51492 "EHLO regular2.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754583AbcCUNYW (ORCPT ); Mon, 21 Mar 2016 09:24:22 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: xf@rock-chips.com X-FST-TO: mturquette@baylibre.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: xf@rock-chips.com X-UNIQUE-TAG: <4e068c943041d134d15ea4f1495bf1b8> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] cpufreq: rockchip: add driver To: Viresh Kumar , =?UTF-8?Q?Heiko_St=c3=bcbner?= References: <1458303004-26445-1-git-send-email-xf@rock-chips.com> <1787319.AFAWVqkdk0@diego> <20160321095049.GD27778@vireshk-i7> <1505152.fhSnu3pvDr@diego> <20160321095855.GE27778@vireshk-i7> Cc: linux@arm.linux.org.uk, rjw@rjwysocki.net, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, wxt@rock-chips.com, zyw@rock-chips.com, jay.xu@rock-chips.com, tim.chen@rock-chips.com, xxx@rock-chips.com, huangtao@rock-chips.com, Stephen Boyd , Michael Turquette From: Feng Xiao Message-ID: <56EFF610.6040402@rock-chips.com> Date: Mon, 21 Mar 2016 21:24:32 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: <20160321095855.GE27778@vireshk-i7> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2016/3/21 17:58, Viresh Kumar 写道: > On 21-03-16, 10:54, Heiko Stübner wrote: >> I hadn't seen that yet ... nice that cpufreq-dt now also supports clusters :-) >> >> The other part still stands though, as we probably should register the >> platform-device somewhere else and not in some new special module. >> >> When everything is using cpufreq-dt now, I guess we could just add it to the >> core rockchip clk-code. Or was there some agreement where this should be done >> (obviously not the devicetree itself)? Of_clk_init is called early, and platform_device_register_simple should be called after devices_init, it will be failed to do it from clk-code. So we need add a new file or add module_init to each clock controller driver(like clk-rk3368.c, clk-rk3399.c) ? > Yeah, there was a discussion around creating a white or black list of platforms > that want to create a platform device for cpufreq-dt. That can be done in > cpufreq-dt.c or a new file, but I haven't worked out on that yet. > > You can do it from clk-code or from the driver that was added in this thread. > Just that you need to match your platform's compatible string before doing that. Rockchip-cpufreq.c depends on ARM_ROCKCHIP_CPUFREQ, it will not be compiled on non-Rockchip platforms. The driver can support all Rockchip SoCs up to now, add of_machine_is_compatible may be redundant ? >