From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756105AbcCUOR4 (ORCPT ); Mon, 21 Mar 2016 10:17:56 -0400 Received: from mail-lf0-f54.google.com ([209.85.215.54]:36597 "EHLO mail-lf0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755146AbcCUORy (ORCPT ); Mon, 21 Mar 2016 10:17:54 -0400 Subject: Re: [PATCH net 09/10] net: hns: adds limitation for debug port mtu To: Yisen Zhuang , davem@davemloft.net References: <1458558401-190165-1-git-send-email-Yisen.Zhuang@huawei.com> <1458558401-190165-10-git-send-email-Yisen.Zhuang@huawei.com> Cc: yankejian@huawei.com, huangdaode@hisilicon.com, salil.mehta@huawei.com, lisheng011@huawei.com, lipeng321@huawei.com, liguozhu@huawei.com, arnd@arndb.de, xieqianqian@huawei.com, andrew@lunn.ch, ivecera@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <56F0028D.4070500@cogentembedded.com> Date: Mon, 21 Mar 2016 17:17:49 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1458558401-190165-10-git-send-email-Yisen.Zhuang@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 03/21/2016 02:06 PM, Yisen Zhuang wrote: > From: Kejian Yan > > If mtu for debug port is set more than 1500, it may cause that packets > are dropped by ppe. So maximum value for debug port should be 1500. > > Signed-off-by: Kejian Yan > Signed-off-by: Yisen Zhuang [...] > diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h > index a69c8af..a68efd6 100644 > --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h > +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h > @@ -28,6 +28,7 @@ struct dsaf_device; > #define MAC_MAX_MTU 9600 > #define MAC_MAX_MTU_V2 9728 > #define MAC_MIN_MTU 68 > +#define MAC_MAX_MTU_DBG MAC_DEFAULT_MTU Please use tabs, not spaces to indent the value, like above [...] MBR, Sergei