From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756792AbcCUQ4x (ORCPT ); Mon, 21 Mar 2016 12:56:53 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:34839 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752150AbcCUQ4w (ORCPT ); Mon, 21 Mar 2016 12:56:52 -0400 Subject: Re: [RESEND RFC 3/3] nvmem: Add 'nvmem-composite' driver To: Andrey Smirnov References: <1456851552-15913-1-git-send-email-andrew.smirnov@gmail.com> <1456851552-15913-4-git-send-email-andrew.smirnov@gmail.com> <56D6F1CA.6020302@linaro.org> <56EA9464.4030107@linaro.org> Cc: linux-kernel@vger.kernel.org, Maxime Ripard , Sascha Hauer , Trent Piepho From: Srinivas Kandagatla Message-ID: <56F027D0.3060405@linaro.org> Date: Mon, 21 Mar 2016 16:56:48 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/03/16 16:12, Andrey Smirnov wrote: >>> a-node { >>> nvmem-cells = <&cell_a &cell_b>, ????; >>> nvmem-cell-names = "some-data", "more-data"; >>> }; >>> >> Should have replied you long back :-) > > No worries :-) > >>> >>> and I want "more-data" to reference only one phandle, how would this be >>> handled? >>> >> yes this would fail. >> >> The device tree compiler would concatenate all the cells and we have no >> means to know where did "more-data" starts. >> >> sounds like composite driver is the way forward. > > What's your preference on "separate driver" vs. "part of the NVMEM > framework"? Should I keep it as a separate driver or try to fold it > into NVMEM core? It does not make sense to have this driver as a separate nvmem provider, can you fold it in the nvmem core itself for now. Thanks, srini > > Thanks, > Andrey >