From: Doug Ledford <dledford@redhat.com>
To: Bart Van Assche <bart.vanassche@sandisk.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Nicholas Bellinger <nab@linux-iscsi.org>,
Sagi Grimberg <sagig@mellanox.com>,
Alex Estrin <alex.estrin@intel.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] ib_srpt: fix a WARN_ON() message
Date: Mon, 21 Mar 2016 16:15:19 -0400 [thread overview]
Message-ID: <56F05657.6050608@redhat.com> (raw)
In-Reply-To: <56ECA8A0.5060502@sandisk.com>
[-- Attachment #1.1: Type: text/plain, Size: 1017 bytes --]
On 3/18/2016 9:17 PM, Bart Van Assche wrote:
> On 03/17/16 22:41, Dan Carpenter wrote:
>> The first argument of WARN_ON() is a condition, so it means the warning
>> message here will just be the name without the ->qp_num information.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c
>> b/drivers/infiniband/ulp/srpt/ib_srpt.c
>> index 1d13090..0bd3cb2 100644
>> --- a/drivers/infiniband/ulp/srpt/ib_srpt.c
>> +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
>> @@ -839,7 +839,7 @@ static void srpt_zerolength_write_done(struct
>> ib_cq *cq, struct ib_wc *wc)
>> if (srpt_set_ch_state(ch, CH_DISCONNECTED))
>> schedule_work(&ch->release_work);
>> else
>> - WARN_ONCE("%s-%d\n", ch->sess_name, ch->qp->qp_num);
>> + WARN_ONCE(1, "%s-%d\n", ch->sess_name, ch->qp->qp_num);
>> }
>> }
>
> Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
Thanks, applied.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
prev parent reply other threads:[~2016-03-21 20:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 5:41 [patch] ib_srpt: fix a WARN_ON() message Dan Carpenter
2016-03-19 1:17 ` Bart Van Assche
2016-03-21 20:15 ` Doug Ledford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F05657.6050608@redhat.com \
--to=dledford@redhat.com \
--cc=alex.estrin@intel.com \
--cc=bart.vanassche@sandisk.com \
--cc=dan.carpenter@oracle.com \
--cc=hal.rosenstock@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=sagig@mellanox.com \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox