From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758110AbcCVArJ (ORCPT <rfc822;w@1wt.eu>);
	Mon, 21 Mar 2016 20:47:09 -0400
Received: from szxga02-in.huawei.com ([119.145.14.65]:3329 "EHLO
	szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751143AbcCVArH (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 21 Mar 2016 20:47:07 -0400
Subject: Re: [PATCH net 01/10] net: hns: bug fix about ping6
To: David Miller <davem@davemloft.net>
References: <1458558401-190165-1-git-send-email-Yisen.Zhuang@huawei.com>
 <1458558401-190165-2-git-send-email-Yisen.Zhuang@huawei.com>
 <20160321.113924.1745428836278929494.davem@davemloft.net>
CC: <yankejian@huawei.com>, <huangdaode@hisilicon.com>,
        <salil.mehta@huawei.com>, <lisheng011@huawei.com>,
        <lipeng321@huawei.com>, <liguozhu@huawei.com>, <arnd@arndb.de>,
        <xieqianqian@huawei.com>, <andrew@lunn.ch>, <ivecera@redhat.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linuxarm@huawei.com>
From: Yisen Zhuang <Yisen.zhuang@huawei.com>
Message-ID: <56F095D2.70604@huawei.com>
Date: Tue, 22 Mar 2016 08:46:10 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <20160321.113924.1745428836278929494.davem@davemloft.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.74.157.38]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A0B0202.56F095E0.007A,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-06-18 04:22:30,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 4d20bb518706c2a63b32dc483a613be6
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



在 2016/3/21 23:39, David Miller 写道:
> From: Yisen Zhuang <Yisen.Zhuang@huawei.com>
> Date: Mon, 21 Mar 2016 19:06:32 +0800
> 
>> From: Kejian Yan <yankejian@huawei.com>
>>
>> The current upstreaming code fails to ping other IPv6 net device, because
>> the enet receives the multicast packets with the src mac addr whick is the
>                                                                 ^^^^^
> 
> "which"

Will fix it in next submit.

Thanks

> 
>> @@ -670,6 +671,14 @@ out_bnum_err:
>>  		return -EFAULT;
>>  	}
>>  
>> +	/* filter out multicast pkt with the same src mac as this port */
>> +	eh = (struct ethhdr *)skb->data;
> 
> Please use the "eth_hdr()" helper.

Will fix it in next submit.

Thanks,

Yisen

> 
> .
>