From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757903AbcCVBUo (ORCPT ); Mon, 21 Mar 2016 21:20:44 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:26456 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750970AbcCVBUm (ORCPT ); Mon, 21 Mar 2016 21:20:42 -0400 Subject: Re: [PATCH net 09/10] net: hns: adds limitation for debug port mtu To: Sergei Shtylyov References: <1458558401-190165-1-git-send-email-Yisen.Zhuang@huawei.com> <1458558401-190165-10-git-send-email-Yisen.Zhuang@huawei.com> <56F0028D.4070500@cogentembedded.com> CC: , , , , , , , , , , , , , From: Yisen Zhuang Message-ID: <56F09DB8.5010908@huawei.com> Date: Tue, 22 Mar 2016 09:19:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56F0028D.4070500@cogentembedded.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.74.157.38] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.56F09DC5.0040,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 596dbec8f850034a7bbbb10dddcc8a79 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2016/3/21 22:17, Sergei Shtylyov 写道: > Hello. > > On 03/21/2016 02:06 PM, Yisen Zhuang wrote: > >> From: Kejian Yan >> >> If mtu for debug port is set more than 1500, it may cause that packets >> are dropped by ppe. So maximum value for debug port should be 1500. >> >> Signed-off-by: Kejian Yan >> Signed-off-by: Yisen Zhuang > [...] >> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h >> index a69c8af..a68efd6 100644 >> --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h >> +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h >> @@ -28,6 +28,7 @@ struct dsaf_device; >> #define MAC_MAX_MTU 9600 >> #define MAC_MAX_MTU_V2 9728 >> #define MAC_MIN_MTU 68 >> +#define MAC_MAX_MTU_DBG MAC_DEFAULT_MTU > > Please use tabs, not spaces to indent the value, like above Will fix it in next version. Thanks, Yisen > > [...] > > MBR, Sergei > > > . >