From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759313AbcCVLUg (ORCPT ); Tue, 22 Mar 2016 07:20:36 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:37058 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932904AbcCVLUD (ORCPT ); Tue, 22 Mar 2016 07:20:03 -0400 Subject: Re: Build error due to commit 458aa76d132dc ("mm/thp/migration: switch from flush_tlb_range to flush_pmd_tlb_range") To: "Aneesh Kumar K.V" References: <20160321200035.GA31544@roeck-us.net> <87k2kvt7p6.fsf@linux.vnet.ibm.com> Cc: linux-kernel@vger.kernel.org, Andrew Morton , linux-snps-arc@lists.infradead.org, Vineet Gupta From: Guenter Roeck Message-ID: <56F12A5D.7040904@roeck-us.net> Date: Tue, 22 Mar 2016 04:19:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <87k2kvt7p6.fsf@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/21/2016 10:14 PM, Aneesh Kumar K.V wrote: > Guenter Roeck writes: > >> [ text/plain ] >> Hi, >> >> Your commit 458aa76d132dc1 ("mm/thp/migration: switch from flush_tlb_range >> to flush_pmd_tlb_range") causes a build error when building >> arcv2:vdk_hs38_smp_defconfig. >> >> include/asm-generic/pgtable.h:799:45: note: in expansion of macro ‘BUILD_BUG’ >> #define flush_pmd_tlb_range(vma, addr, end) BUILD_BUG() >> ^ >> ./arch/arc/include/asm/tlbflush.h:37:13: note: >> in expansion of macro ‘flush_pmd_tlb_range’ >> >> The build triggers the newly introduced BUILD_BUG(). >> >> When building the image without the BUILD_BUG(), ie with no definition >> of flush_pmd_tlb_range(), the problem is gone. This suggests that the >> function is not needed for this build. >> >> I could submit a patch to remove the BUILD_BUG(), but maybe you had a reason >> for introducing it. Can you elaborate why you introduced the BUILD_BUG() ? >> > > Isn't this going to be fixed by an update to ARC tree ? > > http://article.gmane.org/gmane.linux.kernel.mm/148412 > That wasn't a build error ? > I also don't understand why we would hit that BUILD_BUG, if we are not > calling flush_pmd_tlb_range(). > Good question. I'll wait for the commit window to close and report again if needed. Guenter