From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754134AbcCWH3I (ORCPT ); Wed, 23 Mar 2016 03:29:08 -0400 Received: from mx2.suse.de ([195.135.220.15]:35031 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752518AbcCWH24 (ORCPT ); Wed, 23 Mar 2016 03:28:56 -0400 Subject: Re: [PATCH v3 20/23] atari_scsi: Set a reasonable default for cmd_per_lun To: Finn Thain , "James E.J. Bottomley" , "Martin K. Petersen" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20160321023149.604138431@telegraphics.com.au> <20160321023154.853970340@telegraphics.com.au> Cc: Ondrej Zary , Sam Creasey From: Hannes Reinecke Message-ID: <56F245B6.2030007@suse.de> Date: Wed, 23 Mar 2016 08:28:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160321023154.853970340@telegraphics.com.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/21/2016 03:32 AM, Finn Thain wrote: > This setting does not need to be conditional on Atari ST or TT. > > Signed-off-by: Finn Thain > Tested-by: Michael Schmitz > > --- > > Changed since v1: > - Set the default cmd_per_lun to 4 based on test results. > > Changed since v2: > - Revert the default cmd_per_lun to 2, like in the v1 patch, because > a uniform default across all ten 5380 wrapper drivers is worth more > than a tiny improvement in one particular microbenchmark on one system. > Michael tells me that 2 is also the best setting for his Atari Falcon. > > --- > drivers/scsi/atari_scsi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)