From: Sebastian Frias <sf84@laposte.net>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Mason <slash.tmp@free.fr>
Cc: Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>,
Daniel Mack <daniel@zonque.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Mans Rullgard <mans@mansr.com>,
Fabio Estevam <festevam@gmail.com>,
Martin Blumenstingl <martin.blumenstingl@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB
Date: Wed, 23 Mar 2016 11:55:14 +0100 [thread overview]
Message-ID: <56F27612.7080001@laposte.net> (raw)
In-Reply-To: <56F27261.4060005@cogentembedded.com>
Hi Sergei,
On 03/23/2016 11:39 AM, Sergei Shtylyov wrote:
>> gpiod_reset = devm_gpiod_get_optional(dev, "reset",
>> GPIOD_OUT_HIGH);
>
> We shouldn't call _optional() then, should we?
I could imagine the original intention was to be backward compatible.
Indeed, if this call is not optional, systems using AT8030 and lacking a
reset line on DT will have their behaviour affected.
NOTE: they would still work because even if this driver fails to bind a
generic one will take over.
Best regards,
Sebastian
next prev parent reply other threads:[~2016-03-23 10:55 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 17:25 [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias
2016-03-18 12:12 ` Mason
2016-03-18 12:54 ` Uwe Kleine-König
2016-03-18 15:56 ` Sebastian Frias
2016-03-18 19:12 ` Uwe Kleine-König
2016-03-18 19:31 ` Mason
2016-03-18 20:11 ` Uwe Kleine-König
2016-03-18 20:44 ` Mason
2016-03-19 10:01 ` Måns Rullgård
2016-03-21 12:48 ` Sebastian Frias
2016-03-21 13:54 ` Uwe Kleine-König
2016-03-21 15:36 ` Sebastian Frias
2016-03-21 20:12 ` Uwe Kleine-König
2016-03-22 14:34 ` Sebastian Frias
2016-03-22 19:42 ` Uwe Kleine-König
2016-03-23 10:12 ` Sebastian Frias
2016-03-23 10:49 ` [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY Sebastian Frias
2016-03-23 17:40 ` David Miller
2016-03-23 19:42 ` Sergei Shtylyov
2016-03-24 9:55 ` Sebastian Frias
2016-03-24 10:10 ` Sebastian Frias
2016-03-24 13:40 ` Sergei Shtylyov
2016-03-23 10:17 ` [PATCH] net: phy: at803x: don't depend on GPIOLIB Mason
2016-03-23 10:39 ` Sergei Shtylyov
2016-03-23 10:55 ` Sebastian Frias [this message]
2016-03-22 14:34 ` Sebastian Frias
2016-03-21 20:15 ` Sergei Shtylyov
2016-03-21 20:41 ` Uwe Kleine-König
2016-03-21 21:56 ` Sergei Shtylyov
2016-03-22 14:53 ` Sebastian Frias
2016-03-22 14:39 ` Sebastian Frias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F27612.7080001@laposte.net \
--to=sf84@laposte.net \
--cc=daniel@zonque.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=festevam@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mans@mansr.com \
--cc=martin.blumenstingl@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=slash.tmp@free.fr \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox