Re: [RFC PATCH] ARM: exynos_defconfig: Enable Samsung media platform drivers as modules

Krzysztof Kozlowski
2016-03-23T23:47:21Z

On 23.03.2016 23:58, Javier Martinez Canillas wrote:
> There are a bunch of media platform drivers under drivers/media/platform/
> that are for Samsung SoCs but are not being built with exynos_defconfig.
>
> This patch enables them as a module to improve build coverage for these
> drivers and also to allow people use them with proper hardware if modules
> are installed. The S5P MFC driver wasn't enabled since it fails to probe.
>
> Only the boolean Kconfig symbols are enabled as built-in, since drivers
> are not critical and also to keep the kernel binary image size as small
> as possible.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
> Hello Kukjin and Krzysztof,
>
> I'm posting this as a RFC because I don't know if it will add too much bloat
> to a kernel built with exynos_defconfig.
>
> I think it doesn't since the image size only increased 15 KiB which seems to
> be a small price for having these built, but you may have another opinion.

I like enabling as modules whatever look necessary or useful. I don't
see problems if it requires turning other things to built-in. Please go
ahead with the patch (and follow up after Tobias comments).

Best regards,
Krzysztof