From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753501AbcCWXrV (ORCPT ); Wed, 23 Mar 2016 19:47:21 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:18779 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751556AbcCWXrT (ORCPT ); Wed, 23 Mar 2016 19:47:19 -0400 X-AuditID: cbfec7f4-f796c6d000001486-b0-56f32b0258bf Subject: Re: [RFC PATCH] ARM: exynos_defconfig: Enable Samsung media platform drivers as modules To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1458745109-21036-1-git-send-email-javier@osg.samsung.com> Cc: linux-samsung-soc@vger.kernel.org, Kukjin Kim From: Krzysztof Kozlowski Message-id: <56F32AFF.60102@samsung.com> Date: Thu, 24 Mar 2016 08:47:11 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: <1458745109-21036-1-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrFLMWRmVeSWpSXmKPExsVy+t/xy7pM2p/DDKavMbB483YNk8XrF4YW /Y9fM1tc3jWHzWLG+X1MDqwem1Z1snls6b/L7tG3ZRWjx+dNcgEsUVw2Kak5mWWpRfp2CVwZ D/ub2Qoeclb8fbCBpYHxKXsXIyeHhICJxLZZRxkhbDGJC/fWs3UxcnEICSxllOiZsJIFwnnK KHF5bzsbSJWwQJLEjn9XwGwRgVCJfxdvg3ULCbhJnFp7nAnEZhZwkbjwbAcLiM0mYCyxefkS sHpeAQ2Jgy1HwGwWAVWJ9vvfwGxRgQiJJ3NPMkLUCEr8mHwPrJdTwF1i96JeIJsDaKaexP2L WhDj5SU2r3nLPIFRYBaSjlkIVbOQVC1gZF7FKJpamlxQnJSea6hXnJhbXJqXrpecn7uJERLC X3YwLj5mdYhRgINRiYf3BtfnMCHWxLLiytxDjBIczEoivNHKQCHelMTKqtSi/Pii0pzU4kOM 0hwsSuK8c3e9DxESSE8sSc1OTS1ILYLJMnFwSjUwLpHKnLfewjj67MI4kenZYuxt/Bm7XLS7 tufvWzDvENd/4XzxY/5zZK4FMq18rXT68EPpz/YxS6KnzAu/2xV7pclQbbm95dYN5QL7Z03n +2O1h0v5uvrXXI0b0ju2/TasfPro2Jslc87oFFyLXG/0KyM6piGVzViuaQLrtVI+nhUHVWb8 5A7QUmIpzkg01GIuKk4EAGrFmT9dAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23.03.2016 23:58, Javier Martinez Canillas wrote: > There are a bunch of media platform drivers under drivers/media/platform/ > that are for Samsung SoCs but are not being built with exynos_defconfig. > > This patch enables them as a module to improve build coverage for these > drivers and also to allow people use them with proper hardware if modules > are installed. The S5P MFC driver wasn't enabled since it fails to probe. > > Only the boolean Kconfig symbols are enabled as built-in, since drivers > are not critical and also to keep the kernel binary image size as small > as possible. > > Signed-off-by: Javier Martinez Canillas > > --- > Hello Kukjin and Krzysztof, > > I'm posting this as a RFC because I don't know if it will add too much bloat > to a kernel built with exynos_defconfig. > > I think it doesn't since the image size only increased 15 KiB which seems to > be a small price for having these built, but you may have another opinion. I like enabling as modules whatever look necessary or useful. I don't see problems if it requires turning other things to built-in. Please go ahead with the patch (and follow up after Tobias comments). Best regards, Krzysztof