From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757033AbcCXJXu (ORCPT ); Thu, 24 Mar 2016 05:23:50 -0400 Received: from smtp-out-033.synserver.de ([212.40.185.33]:1052 "EHLO smtp-out-033.synserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752990AbcCXJXm (ORCPT ); Thu, 24 Mar 2016 05:23:42 -0400 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 29431 Subject: Re: [PATCH 1/1] iio: fix config watermark initial value To: Irina Tirdea , Jonathan Cameron , linux-iio@vger.kernel.org References: <1458810585-24555-1-git-send-email-irina.tirdea@intel.com> Cc: linux-kernel@vger.kernel.org, Hartmut Knaack , Peter Meerwald , Octavian Purdila From: Lars-Peter Clausen Message-ID: <56F3B217.8040206@metafoo.de> Date: Thu, 24 Mar 2016 10:23:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <1458810585-24555-1-git-send-email-irina.tirdea@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/24/2016 10:09 AM, Irina Tirdea wrote: > config structure is set to 0 when updating the buffers, so by > default config->watermark will be 0. When computing the minimum > between config->watermark and the buffer->watermark or > insert_buffer-watermark, this will always be 0 regardless of the > value set by the user for the buffer. > > Set as initial value for config->watermark the maximum allowed > value so that the minimum value will always be set from one of the > buffers. > > Signed-off-by: Irina Tirdea Looks good. This bug was my fault, sorry. Fixes: f0566c0c405d ("iio: Set device watermark based on watermark of all attached buffers") > --- > drivers/iio/industrialio-buffer.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c > index b976332..90462fc 100644 > --- a/drivers/iio/industrialio-buffer.c > +++ b/drivers/iio/industrialio-buffer.c > @@ -653,6 +653,7 @@ static int iio_verify_update(struct iio_dev *indio_dev, > unsigned int modes; > > memset(config, 0, sizeof(*config)); > + config->watermark = ~0; > > /* > * If there is just one buffer and we are removing it there is nothing >