From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: "Sebastian Frias" <sf84@laposte.net>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Daniel Mack <daniel@zonque.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
mason <slash.tmp@free.fr>,
Florian Fainelli <f.fainelli@gmail.com>,
Mans Rullgard <mans@mansr.com>,
Fabio Estevam <festevam@gmail.com>,
Martin Blumenstingl <martin.blumenstingl@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY
Date: Thu, 24 Mar 2016 16:40:58 +0300 [thread overview]
Message-ID: <56F3EE6A.5040304@cogentembedded.com> (raw)
In-Reply-To: <56F3BD28.4080908@laposte.net>
On 03/24/2016 01:10 PM, Sebastian Frias wrote:
>>> What I don't understand is why the link_change_notify() method ptr is
>>> populated for all 3 supported chips while only being needed on 8030...
>>
>> You are right.
>
> I made the patch but I'm unsure about it because it could conflict with
> yours.
> I mean, I think you submitted a patch to change the GPIO handling on the
> link_change_notify() function, right?
> Well, if we only register the callback for the AT8030, then there is no
> more need for the callback to check the PHY ID.
> However, if I change that, the whole block moves as I remove one
> indentation level (the one required by the PHY ID check).
>
> Any suggestions on how to create a patch that won't conflict? I probably
> need to use a tree that already has your patch applied.
My patch is already in Linus' tree, so should be merged back from net.git
into net-next.git
soon. I suggest that you wait until net-next is open again.
> Best regards,
>
> Sebastian
MBR, Sergei
next prev parent reply other threads:[~2016-03-24 13:41 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 17:25 [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias
2016-03-18 12:12 ` Mason
2016-03-18 12:54 ` Uwe Kleine-König
2016-03-18 15:56 ` Sebastian Frias
2016-03-18 19:12 ` Uwe Kleine-König
2016-03-18 19:31 ` Mason
2016-03-18 20:11 ` Uwe Kleine-König
2016-03-18 20:44 ` Mason
2016-03-19 10:01 ` Måns Rullgård
2016-03-21 12:48 ` Sebastian Frias
2016-03-21 13:54 ` Uwe Kleine-König
2016-03-21 15:36 ` Sebastian Frias
2016-03-21 20:12 ` Uwe Kleine-König
2016-03-22 14:34 ` Sebastian Frias
2016-03-22 19:42 ` Uwe Kleine-König
2016-03-23 10:12 ` Sebastian Frias
2016-03-23 10:49 ` [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY Sebastian Frias
2016-03-23 17:40 ` David Miller
2016-03-23 19:42 ` Sergei Shtylyov
2016-03-24 9:55 ` Sebastian Frias
2016-03-24 10:10 ` Sebastian Frias
2016-03-24 13:40 ` Sergei Shtylyov [this message]
2016-03-23 10:17 ` [PATCH] net: phy: at803x: don't depend on GPIOLIB Mason
2016-03-23 10:39 ` Sergei Shtylyov
2016-03-23 10:55 ` Sebastian Frias
2016-03-22 14:34 ` Sebastian Frias
2016-03-21 20:15 ` Sergei Shtylyov
2016-03-21 20:41 ` Uwe Kleine-König
2016-03-21 21:56 ` Sergei Shtylyov
2016-03-22 14:53 ` Sebastian Frias
2016-03-22 14:39 ` Sebastian Frias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F3EE6A.5040304@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=daniel@zonque.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=festevam@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mans@mansr.com \
--cc=martin.blumenstingl@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sf84@laposte.net \
--cc=slash.tmp@free.fr \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox