From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752171AbcCYJuj (ORCPT ); Fri, 25 Mar 2016 05:50:39 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:23977 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751831AbcCYJuh (ORCPT ); Fri, 25 Mar 2016 05:50:37 -0400 X-AuditID: cbfec7f5-f792a6d000001302-a5-56f509e9a665 Subject: Re: [PATCH v3 3/8] clk: samsung: exynos3250: Add MMC2 clock To: Chanwoo Choi References: <1458027490-13787-1-git-send-email-cw00.choi@samsung.com> <1458027490-13787-4-git-send-email-cw00.choi@samsung.com> <56F47ABC.7060006@samsung.com> Cc: k.kozlowski@samsung.com, kgene@kernel.org, tomasz.figa@gmail.com, jh80.chung@samsung.com, andi.shyti@samsung.com, inki.dae@samsung.com, sw0312.kim@samsung.com, pankaj.dubey@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org From: Sylwester Nawrocki Message-id: <56F509E6.7080807@samsung.com> Date: Fri, 25 Mar 2016 10:50:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: <56F47ABC.7060006@samsung.com> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrOLMWRmVeSWpSXmKPExsVy+t/xa7ovOb+GGTzZyWGx/cgzVovrX56z Wsw/co7VYtL9CSwWN361sVq8fmFo0f/4NbPFpsfXWC0u75rDZjHj/D4mi0Vbv7BbzJj8ks1i 1a4/jA68Hjtn3WX32LSqk81j85J6j74tqxg9Pm+SC2CN4rJJSc3JLEst0rdL4MrYcGsfW8FC 9orWKf/ZGxj/sHYxcnJICJhItJ3dzgRhi0lcuLeeDcQWEljKKNF/LbyLkQvIfs4o8efHPLAi YQEXiW8LJzOD2CICGhIz/15hhChaxCjRtqOdBcRhFjjOJNHZeJwFpIpNwFCi92gfI4jNK6Al MffxEbBuFgFViS0P9oLFRQUiJJ7MPQlVIyjxY/I9sF5OAW2J+bt2ANVzAA1Vl5gyJRckzCwg L7F5zVvmCYwCs5B0zEKomoWkagEj8ypG0dTS5ILipPRcI73ixNzi0rx0veT83E2MkOj4uoNx 6TGrQ4wCHIxKPLwvXL6ECbEmlhVX5h5ilOBgVhLhtQfGlhBvSmJlVWpRfnxRaU5q8SFGaQ4W JXHembvehwgJpCeWpGanphakFsFkmTg4pRoYox/daNi7bqXI3aONOT/lmnImH/Msm+Lr32XS urY2qfFs3x/v9MeN869vmHlRYRePzMVcjQPB+2e/Vw0va8gXixG1vmZZcNIz4uMV4RWuL/7G 3fx0/JvZ94cybTeUhDnzlOt/Zfy5/27v4e6Me9HJt2tzH7B7XdSaeddcgk97tWjhQbEAU9k8 JZbijERDLeai4kQA5W/q6YoCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chanwoo, On 03/25/2016 12:39 AM, Chanwoo Choi wrote: > diff --git a/include/dt-bindings/clock/exynos3250.h > b/include/dt-bindings/clock/exynos3250.h >> index ddb874130d86..c796ff02ceeb 100644 >> --- a/include/dt-bindings/clock/exynos3250.h >> +++ b/include/dt-bindings/clock/exynos3250.h ... >> -#define CLK_NR_CLKS 249 >> +#define CLK_NR_CLKS 250 What do you think about putting all the changes to include/dt-bindings/ clock/exynos3250.h into a separate patch? Now in patch 3/8 there is being changed again what was added in patch 2/8. However, my main point is to have a minimum required in a common topic branch for the clk and the arm-soc trees, so there is no need for arm-soc to pull all the drives/clk changes. It might not be that sensible in case of just those 2 patches in your series, nevertheless it would be good to keep that in mind for future submissions. -- Thanks, Sylwester