From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752072AbcCYLMf (ORCPT ); Fri, 25 Mar 2016 07:12:35 -0400 Received: from mail-lf0-f53.google.com ([209.85.215.53]:35343 "EHLO mail-lf0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751127AbcCYLMd (ORCPT ); Fri, 25 Mar 2016 07:12:33 -0400 Subject: Re: [PATCH] usb: gadget: fsl_udc_core: Fix pullup status To: Dmitry Osipenko , Felipe Balbi , Li Yang References: <1458861242-3906-1-git-send-email-digetx@gmail.com> Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Suresh Gupta From: Sergei Shtylyov Message-ID: <56F51D1D.8020804@cogentembedded.com> Date: Fri, 25 Mar 2016 14:12:29 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1458861242-3906-1-git-send-email-digetx@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 3/25/2016 2:14 AM, Dmitry Osipenko wrote: > udc->softconnect should be set regardless of the VBUS state, otherwise > the USB peripheral device, connected during suspend, won't be detected > since can_pullup() would return false the UDC controller won't be enabled. > > Fixes: 252455c40316 (usb: gadget: fsl driver pullup fix) > Signed-off-by: Dmitry Osipenko > --- > drivers/usb/gadget/udc/fsl_udc_core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c b/drivers/usb/gadget/udc/fsl_udc_core.c > index aab5221..118cf7a 100644 > --- a/drivers/usb/gadget/udc/fsl_udc_core.c > +++ b/drivers/usb/gadget/udc/fsl_udc_core.c > @@ -1220,10 +1220,11 @@ static int fsl_pullup(struct usb_gadget *gadget, int is_on) > > udc = container_of(gadget, struct fsl_udc, gadget); > > + udc->softconnect = (is_on != 0); !!is_on? Parens not needed anyway though. > + > if (!udc->vbus_active) > return -EOPNOTSUPP; > > - udc->softconnect = (is_on != 0); > if (can_pullup(udc)) > fsl_writel((fsl_readl(&dr_regs->usbcmd) | USB_CMD_RUN_STOP), > &dr_regs->usbcmd); MBR, Sergei