From: Dmitry Osipenko <digetx@gmail.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Felipe Balbi <balbi@kernel.org>, Li Yang <leoli@freescale.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Suresh Gupta <suresh.gupta@freescale.com>
Subject: Re: [PATCH] usb: gadget: fsl_udc_core: Fix pullup status
Date: Fri, 25 Mar 2016 16:03:18 +0300 [thread overview]
Message-ID: <56F53716.8050000@gmail.com> (raw)
In-Reply-To: <56F51D1D.8020804@cogentembedded.com>
Hello Sergei,
25.03.2016 14:12, Sergei Shtylyov пишет:
[snip]
>>
>> udc = container_of(gadget, struct fsl_udc, gadget);
>>
>> + udc->softconnect = (is_on != 0);
>
> !!is_on? Parens not needed anyway though.
>
Okay :) I'll change to it in V2 as well as a bit messed up commit message.
Thanks for the comment!
[snip]
--
Dmitry
prev parent reply other threads:[~2016-03-25 13:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 23:14 [PATCH] usb: gadget: fsl_udc_core: Fix pullup status Dmitry Osipenko
2016-03-25 11:12 ` Sergei Shtylyov
2016-03-25 13:03 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F53716.8050000@gmail.com \
--to=digetx@gmail.com \
--cc=balbi@kernel.org \
--cc=leoli@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=suresh.gupta@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox