From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752655AbcCYNDY (ORCPT <rfc822;w@1wt.eu>);
	Fri, 25 Mar 2016 09:03:24 -0400
Received: from mail-lb0-f182.google.com ([209.85.217.182]:36300 "EHLO
	mail-lb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751379AbcCYNDW (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 25 Mar 2016 09:03:22 -0400
Subject: Re: [PATCH] usb: gadget: fsl_udc_core: Fix pullup status
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
        Felipe Balbi <balbi@kernel.org>, Li Yang <leoli@freescale.com>
References: <1458861242-3906-1-git-send-email-digetx@gmail.com>
 <56F51D1D.8020804@cogentembedded.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Suresh Gupta <suresh.gupta@freescale.com>
From: Dmitry Osipenko <digetx@gmail.com>
Message-ID: <56F53716.8050000@gmail.com>
Date: Fri, 25 Mar 2016 16:03:18 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
MIME-Version: 1.0
In-Reply-To: <56F51D1D.8020804@cogentembedded.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Sergei,

25.03.2016 14:12, Sergei Shtylyov пишет:
[snip]
>>
>>       udc = container_of(gadget, struct fsl_udc, gadget);
>>
>> +    udc->softconnect = (is_on != 0);
>
>     !!is_on? Parens not needed anyway though.
>

Okay :) I'll change to it in V2 as well as a bit messed up commit message. 
Thanks for the comment!

[snip]

-- 
Dmitry