From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753495AbcC0LqK (ORCPT ); Sun, 27 Mar 2016 07:46:10 -0400 Received: from mail-lf0-f47.google.com ([209.85.215.47]:35531 "EHLO mail-lf0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751152AbcC0LqI (ORCPT ); Sun, 27 Mar 2016 07:46:08 -0400 Subject: Re: [PATCH] drivers : Remove unnecessary void pointer conversions To: Bhaskar Jupudi , davem@davemloft.net, igal.liberman@freescale.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1459050140-14621-1-git-send-email-njupudi@ucsc.edu> From: Sergei Shtylyov Message-ID: <56F7C7FC.9020001@cogentembedded.com> Date: Sun, 27 Mar 2016 14:46:04 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1459050140-14621-1-git-send-email-njupudi@ucsc.edu> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 3/27/2016 6:42 AM, Bhaskar Jupudi wrote: > Explicit void pointer conversion is unnecessary > because the conversions to and from a void pointer > are always implicit in 'C'. Changed two instances > of such conversions. > > > Signed-off-by: Bhaskar Jupudi > --- > This patch is based on Kernel Janitors To-Do list > > drivers/net/ethernet/freescale/fman/fman.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/freescale/fman/fman.c b/drivers/net/ethernet/freescale/fman/fman.c > index 623aa1c..8719f7b 100644 > --- a/drivers/net/ethernet/freescale/fman/fman.c > +++ b/drivers/net/ethernet/freescale/fman/fman.c > @@ -2668,7 +2668,7 @@ static struct fman *read_dts_node(struct platform_device *of_dev) > > fm_node = of_node_get(of_dev->dev.of_node); > > - u32_prop = (const u32 *)of_get_property(fm_node, "cell-index", &lenp); > + u32_prop = of_get_property(fm_node, "cell-index", &lenp); This function returns a pointer to big-endian data, no? > if (!u32_prop) { > dev_err(&of_dev->dev, "%s: of_get_property(%s, cell-index) failed\n", > __func__, fm_node->full_name); > @@ -2724,7 +2724,7 @@ static struct fman *read_dts_node(struct platform_device *of_dev) > /* Rounding to MHz */ > fman->dts_params.clk_freq = DIV_ROUND_UP(clk_rate, 1000000); > > - u32_prop = (const u32 *)of_get_property(fm_node, > + u32_prop = of_get_property(fm_node, Same here... > "fsl,qman-channel-range", > &lenp); Please re-align these continuation lines. [...] MBR, Sergei