From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753329AbcC1AI7 (ORCPT ); Sun, 27 Mar 2016 20:08:59 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:42234 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751739AbcC1AI5 (ORCPT ); Sun, 27 Mar 2016 20:08:57 -0400 X-AuditID: cbfec7f4-f796c6d000001486-2f-56f87614805f Subject: Re: [PATCH] ARM: dts: exynos: Fix invalid maximum voltage for buck9 supplying SD card To: Javier Martinez Canillas , Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org References: <1458807125-13580-1-git-send-email-k.kozlowski@samsung.com> <56F4D070.4020403@osg.samsung.com> Cc: Ulf Hansson , Mark Brown , Ivaylo Dimitrov From: Krzysztof Kozlowski Message-id: <56F87610.2040304@samsung.com> Date: Mon, 28 Mar 2016 09:08:48 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: <56F4D070.4020403@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCLMWRmVeSWpSXmKPExsVy+t/xy7oiZT/CDPa3m1lMffiEzWL+kXOs FkuuHGK3ePN2DZPF6xeGFv2PXzNbbHp8jdXi8q45bBZH/vczWsw4v4/J4vjacAduj52z7rJ7 bFrVyeZx59oeNo/NS+o9tvQDhfq2rGL0+LxJLoA9issmJTUnsyy1SN8ugStjxdT8gusiFfN+ NzI3MH4S6GLk5JAQMJHYvuU8E4QtJnHh3nq2LkYuDiGBpYwSB543MEE4Txkl+u5MZQSpEhZI kPhwuIERJCEi8INRYv6TJhaQhJBAjsT9VWtZQWxmgSqJice/g8XZBIwlNi9fwgZi8wpoSSza cRLMZhFQldi76yOYLSoQIfFk7klGiBpBiR+T7wH1cnBwCuhLPPokB2IyC+hJ3L+oBTFdXmLz mrfMExgFZiFpmIVQNQtJ1QJG5lWMoqmlyQXFSem5hnrFibnFpXnpesn5uZsYIXHxZQfj4mNW hxgFOBiVeHgzLH+ECbEmlhVX5h5ilOBgVhLhrUoDCvGmJFZWpRblxxeV5qQWH2KU5mBREued u+t9iJBAemJJanZqakFqEUyWiYNTqoFx08UPIY94f2qxqrw0ESn4tmv+8TWs/lmftz+o3drV wtQbEar30uqtwsf1dQfjf07q87649Jm8nPKqdhWDFVFSDNPPlfJcfR143//csh1HMyTyBdUX Lqyf2Hh8ydc1KzVrItets9uXWta/vOb6SQmF2uKg7nc/TD7t0VzgM3/r6oIfPbySUl+eKrEU ZyQaajEXFScCAPCDt4iHAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25.03.2016 14:45, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 03/24/2016 05:12 AM, Krzysztof Kozlowski wrote: >> The buck9 regulator of S2MPS11 PMIC had incorrect maximum voltage - >> lower by 5 mV than specified by datasheet. This buck9 provides power to >> other regulators, including LDO13 and LDO19 which supply the MMC2 (SD >> card). >> >> When constraints were applied, the depending regulators were not >> providing enough power, leading to SD card detection errors: >> mmc1: card never left busy state >> mmc1: error -110 whilst initialising SD card >> >> Fixes: 86a2d2ac5e5d ("ARM: dts: Add dts file for Odroid XU3 board") >> Signed-off-by: Krzysztof Kozlowski >> >> --- >> >> The issue can be reproduced on next-20160324 with >> bae4fdc88d7f7dda1 (regulator: core: Ensure we are at least in bounds for our constraints). >> --- >> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi >> index 1bd507bfa750..82b2ba632cf6 100644 >> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi >> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi >> @@ -299,7 +299,7 @@ >> buck9_reg: BUCK9 { >> regulator-name = "vdd_2.8v_ldo"; >> regulator-min-microvolt = <3000000>; >> - regulator-max-microvolt = <3750000>; >> + regulator-max-microvolt = <3755000>; >> regulator-always-on; >> regulator-boot-on; >> }; >> > > I tested next-20160324 + $SUBJECT on an Odroid XU4 (with exynos_defconfig) > and while it's true that the patch makes the SD card error to go away, I see > that the s2mps11 regulator driver fails to probe due an -EINVAL being return > by machine_constraints_voltage() -> _regulator_do_set_voltage(): > > [ 1.710300] vdd_2.8v_ldo: failed to apply 3755000-3755000uV constraint(-22) > [ 1.716387] s2mps11-pmic s2mps11-regulator: regulator init failed for 46 > [ 1.734878] s2mps11-pmic: probe of s2mps11-regulator failed with error -22 Oh, damn, so the fix was only because driver failed to probe (which I missed). This explains Friday's next failures. I'll drop it from next because it makes more harm than good... BR, Krzysztof > I wonder how neither Markus nor you saw this issue when testing so maybe I'm > doing something wrong? Since AFAICT it's only working because the driver fails > to probe so the same effect can be achieved disabling CONFIG_REGULATOR_S2MPS11. > > Best regards, >