From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752960AbcC1Ao5 (ORCPT ); Sun, 27 Mar 2016 20:44:57 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:43421 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752037AbcC1Aoz (ORCPT ); Sun, 27 Mar 2016 20:44:55 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee690-f79e56d0000012c4-67-56f87e845868 Content-transfer-encoding: 8BIT Message-id: <56F87E83.7060100@samsung.com> Date: Mon, 28 Mar 2016 09:44:51 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Sylwester Nawrocki Cc: k.kozlowski@samsung.com, kgene@kernel.org, tomasz.figa@gmail.com, jh80.chung@samsung.com, andi.shyti@samsung.com, inki.dae@samsung.com, sw0312.kim@samsung.com, pankaj.dubey@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 3/8] clk: samsung: exynos3250: Add MMC2 clock References: <1458027490-13787-1-git-send-email-cw00.choi@samsung.com> <1458027490-13787-4-git-send-email-cw00.choi@samsung.com> <56F47ABC.7060006@samsung.com> <56F509E6.7080807@samsung.com> In-reply-to: <56F509E6.7080807@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrFIsWRmVeSWpSXmKPExsWyRsSkWLel7keYwclGLovtR56xWsw/co7V YtL9CSwWN361sVq8fmFo0f/4NbPFpsfXWC0u75rDZjHj/D4mi0Vbv7BbHH7TzmoxY/JLNotV u/4wOvB67Jx1l91j06pONo/NS+o9+rasYvT4vEkugDWKyyYlNSezLLVI3y6BK2Nt33zWgoPc FRtvrWdvYFzG2cXIySEhYCLROGEHG4QtJnHh3nowW0hgBaPEnQfBMDU9fz+zQ8SXMkocuKsA YvMKCEr8mHyPpYuRg4NZQF7iyKVsCFNdYsqU3C5GLqDqB4wS37dPZIUo15I48X85E4jNIqAq cWzvajCbDSi+/8UNNpBeUYEIie4TlSBhEQF9iSWrLrKBzGEWOM4k0dl4nAUkISzgIvFt4WRm iAUHGSWmtZ0BS3AKaEvsvf6OHeLmv+wSbzZkQSwTkPg2+RDYnRICshKbDjBDlEhKHFxxg2UC o9gsJN/MQvhmFsI3CxiZVzGKphYkFxQnpReZ6BUn5haX5qXrJefnbmIERunpf88m7GC8d8D6 EKMAB6MSD2+G5Y8wIdbEsuLK3EOMpkA3TGSWEk3OB6aCvJJ4Q2MzIwtTE1NjI3NLMyVx3tdS P4OFBNITS1KzU1MLUovii0pzUosPMTJxcEo1MDI5PnVNjz3ux/JEP28Wb+7266oT+5kKxS+5 az88u52bo573ubZWyd7iquVVmQqhdv5LQzfL8m9YNrn53xw9Zt0sxvW3osPYW/oCKoq513mn 7E73L6o2TZUutJ21YNbVDb5ijfWiE4JWSvdd/efamH6xu8rtf6LY2ZvHwi03zxBYuP7v2rnJ SizFGYmGWsxFxYkAc9Tayc0CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkleLIzCtJLcpLzFFi42I5/e+xgG5L3Y8wg18bWSy2H3nGajH/yDlW i0n3J7BY3PjVxmrx+oWhRf/j18wWmx5fY7W4vGsOm8WM8/uYLBZt/cJucfhNO6vFjMkv2SxW 7frD6MDrsXPWXXaPTas62Tw2L6n36NuyitHj8ya5ANaoBkabjNTElNQihdS85PyUzLx0WyXv 4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfMHKAblRTKEnNKgUIBicXFSvp2mCaEhrjpWsA0 Ruj6hgTB9RgZoIGENYwZa/vmsxYc5K7YeGs9ewPjMs4uRk4OCQETiZ6/n9khbDGJC/fWs4HY QgJLGSUO3FUAsXkFBCV+TL7H0sXIwcEsIC9x5FI2hKkuMWVKbhcjF1D1A0aJ79snskKUa0mc +L+cCcRmEVCVOLZ3NZjNBhTf/+IGG0ivqECERPeJSpCwiIC+xJJVF9lA5jALHGeS6Gw8zgKS EBZwkfi2cDIzxIKDjBLT2s6AJTgFtCX2Xn/HPoFRYBaS82YhnDcL4bwFjMyrGCVSC5ILipPS cw3zUsv1ihNzi0vz0vWS83M3MYKTwTOpHYwHd7kfYhTgYFTi4c2w/BEmxJpYVlyZe4hRgoNZ SYS3Kg0oxJuSWFmVWpQfX1Sak1p8iNEU6L+JzFKiyfnARJVXEm9obGJmZGlkbmhhZGyuJM77 +P+6MCGB9MSS1OzU1ILUIpg+Jg5OqQZG2ebl4r/++P7dZu9+/8rVSYwLOdTjg1R4TxzqvhKl efNo387Svz9mT73Y9jNP70TrniO2F984zpvXucvoAF+xxNI5U5tE16e2n5h2VtHpYpfBt9Om ejLGVqUaORrla/6IyfBOelMh4DKp1Pfz2+T5aYX5wf84Dm0rmP9tSmD3OdWHwgk5WnXWSizF GYmGWsxFxYkAxS/fyRwDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sylwester, On 2016년 03월 25일 18:50, Sylwester Nawrocki wrote: > Hi Chanwoo, > > On 03/25/2016 12:39 AM, Chanwoo Choi wrote: >> diff --git a/include/dt-bindings/clock/exynos3250.h >> b/include/dt-bindings/clock/exynos3250.h >>> index ddb874130d86..c796ff02ceeb 100644 >>> --- a/include/dt-bindings/clock/exynos3250.h >>> +++ b/include/dt-bindings/clock/exynos3250.h > ... >>> -#define CLK_NR_CLKS 249 >>> +#define CLK_NR_CLKS 250 > > What do you think about putting all the changes to include/dt-bindings/ > clock/exynos3250.h into a separate patch? Now in patch 3/8 there > is being changed again what was added in patch 2/8. However, my main > point is to have a minimum required in a common topic branch for the clk > and the arm-soc trees, so there is no need for arm-soc to pull all > the drives/clk changes. > It might not be that sensible in case of just those 2 patches in your > series, nevertheless it would be good to keep that in mind for future > submissions. You mean that separate patch1 include only the new clock id about both UART2 and MMC2 and the patch2/patch3 just use the new clock id as following: patch1 dt-bindings: Add the clock id of UART2 and MMC2 for Exynos3250 patch2 clk: samsung: exynos3250: Add UART2 clock patch3 clk: samsung: exynos3250: Add MMC2 clock As far as I understand it is that right? If it is ok, I'll modify it on v4 patchset as you comment. Best Regards, Chanwoo Choi