From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753610AbcC1Df2 (ORCPT ); Sun, 27 Mar 2016 23:35:28 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:33696 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751367AbcC1DfZ (ORCPT ); Sun, 27 Mar 2016 23:35:25 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee68d-f79e86d0000012da-d4-56f8a67aa4f3 Content-transfer-encoding: 8BIT Message-id: <56F8A679.5010009@samsung.com> Date: Mon, 28 Mar 2016 12:35:21 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: myungjoo.ham@samsung.com, =?UTF-8?B?67CV6rK966+8?= , =?UTF-8?B?7YGs7Ims7Iuc7Yag7ZSE?= , "kgene@kernel.org" Cc: "rjw@rjwysocki.net" , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "linux@arm.linux.org.uk" , "linux.amoon@gmail.com" , "m.reichl@fivetechno.de" , "tjakobi@math.uni-bielefeld.de" , =?UTF-8?B?64yA7J246riw?= , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH v6 04/21] PM / devfreq: Add new DEVFREQ_TRANSITION_NOTIFIER notifier References: <190611333.27621459133690582.JavaMail.weblogic@epmlwas02a> In-reply-to: <190611333.27621459133690582.JavaMail.weblogic@epmlwas02a> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrLIsWRmVeSWpSXmKPExsWyRsSkULdq2Y8wg1t3BCzmHznHatH/ZiGr xblXKxktJt2fwGLx+oWhRf/j18wWZ5vesFtsenyN1eLyrjlsFp97jzBazDi/j8li3cZb7Ba3 L/NavDzyg9Fi6fWLTBa3G1ewWUyYvpbF4szpS6wWrXuPsFu0rf7A6iDisWbeGkaPluYeNo/L fb1MHrfu1HvsnHWX3WPl8i9sHptWdbJ5bF5S7/HvGLvHlqvtLB59W1YxenzeJBfAE8Vlk5Ka k1mWWqRvl8CV0bP7AlvBS76Khk1XWRoYp/J0MXJwSAiYSJx+yN3FyAlkiklcuLeerYuRi0NI YAWjRGdDOxtEwkTiSeMNqMQsRokz0/4zgyR4BQQlfky+xwIyiFlAXuLIpWwIU11iypRckAoh gQeMEtMuZ0FUa0k0rV4KNpJFQFVi9p8F7CA2G1B8/wuQ8RwcogIREt0nKkE2iQjsZpSY838t E4jDLDCBXeLP3VvMIEXCAlESz44IQcx3kzi4YC3YHE4Bd4m++/8YQeolBB5wSNx/cgpqmYDE t8mHWCD+lZXYdIAZ4i1JiYMrbrBMYBSbheSZWQjPzEJ4ZgEj8ypG0dSC5ILipPQiQ73ixNzi 0rx0veT83E2MwFRx+t+z3h2Mtw9YH2IU4GBU4uHNsPwRJsSaWFZcmXuI0RTohonMUqLJ+cCE lFcSb2hsZmRhamJqbGRuaaYkzqso9TNYSCA9sSQ1OzW1ILUovqg0J7X4ECMTB6dUA+N8V13h M8cFP8z/rtS3YtKn4/vOTD/DXr1+RsBnuw9fdGc3morb17+psb22cl5CzQSduDMHtb2Nltic nb9PM9jm9tT0Fw53r89pcinfO3HnscSlnK7Lt5QJLZwUYf+gwVs5r9mL4frRHj2VsN6lh1Rr F20v5tm9aMY+C0uTQyyzu4/yOrBFmbkpsRRnJBpqMRcVJwIAA0U+dBADAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNKsWRmVeSWpSXmKPExsVy+t9jQd2qZT/CDM595LCYf+Qcq0X/m4Ws FuderWS0mHR/AovF6xeGFv2PXzNbnG16w26x6fE1VovLu+awWXzuPcJoMeP8PiaLdRtvsVvc vsxr8fLID0aLpdcvMlncblzBZjFh+loWizOnL7FatO49wm7RtvoDq4OIx5p5axg9Wpp72Dwu 9/Uyedy6U++xc9Zddo+Vy7+weWxa1cnmsXlJvce/Y+weW662s3j0bVnF6PF5k1wAT1QDo01G amJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO0JtKCmWJOaVA oYDE4mIlfTtME0JD3HQtYBojdH1DguB6jAzQQMIaxoye3RfYCl7yVTRsusrSwDiVp4uRk0NC wETiSeMNNghbTOLCvfVANheHkMAsRokz0/4zgyR4BQQlfky+x9LFyMHBLCAvceRSNoSpLjFl Si5IhZDAA0aJaZezIKq1JJpWLwUbySKgKjH7zwJ2EJsNKL7/BcgqDg5RgQiJ7hOVIJtEBHYz Ssz5v5YJxGEWmMAu8efuLWaQImGBKIlnR4Qg5rtJHFywFmwOp4C7RN/9f4wTGIFuRDhuFsJx sxCOW8DIvIpRIrUguaA4KT3XMC+1XK84Mbe4NC9dLzk/dxMjOCE9k9rBeHCX+yFGAQ5GJR7e DMsfYUKsiWXFlbmHGCU4mJVEeLfOBQrxpiRWVqUW5ccXleakFh9iNAV6byKzlGhyPjBZ5pXE GxqbmBlZGpkbWhgZmyuJ8z7+vy5MSCA9sSQ1OzW1ILUIpo+Jg1OqgXFngJH8M2nzzQLT+o7c vpb+zGTh/nd6nNHftr4tkJHTLj6+vLLhn/slgeywk4uEGN5fflTGt6O+c6P53zNObc1bZlq8 usL5TGv++ptJv4PuuZ3ualR6XSf38fcXH0/VxsOa7s+OezJVKMU/fOm7q0F7yekGO9M1+QET Hb60/Y84f19FmzG/9ZUSS3FGoqEWc1FxIgCvs5mMXgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 03월 28일 11:54, MyungJoo Ham wrote: >> >> This patch adds the new DEVFREQ_TRANSITION_NOTIFIER notifier to send >> the notification when the frequency of device is changed. >> This notifier has two state as following: >> - DEVFREQ_PRECHANGE : Notify it before chaning the frequency of device >> - DEVFREQ_POSTCHANGE : Notify it after changed the frequency of device >> >> And this patch adds the resourced-managed function to release the resource >> automatically when error happen. >> >> Signed-off-by: Chanwoo Choi >> [m.reichl and linux.amoon: Tested it on exynos4412-odroidu3 board] >> Tested-by: Markus Reichl >> Tested-by: Anand Moon >> --- >> drivers/devfreq/devfreq.c | 163 +++++++++++++++++++++++++++++++++++++++++++++- >> include/linux/devfreq.h | 58 ++++++++++++++++- >> 2 files changed, 219 insertions(+), 2 deletions(-) > > [] > >> diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h >> index aa0b8424ebc3..152ea342529c 100644 >> --- a/include/linux/devfreq.h >> +++ b/include/linux/devfreq.h >> @@ -19,6 +19,13 @@ >> >> #define DEVFREQ_NAME_LEN 16 >> >> +/* DEVFREQ notifier interface */ >> +#define DEVFREQ_TRANSITION_NOTIFIER (0) >> + >> +/* Transition notifiers of DEVFREQ_TRANSITION_NOTIFIER */ >> +#define DEVFREQ_PRECHANGE (0) >> +#define DEVFREQ_POSTCHANGE (1) >> + >> struct devfreq; >> >> /** >> @@ -177,6 +184,13 @@ struct devfreq { >> unsigned int *trans_table; >> unsigned long *time_in_state; >> unsigned long last_stat_updated; >> + >> + struct srcu_notifier_head transition_notifier_list; >> +}; > > Like other properties of struct devfreq, please add > descriptions above. Other than that, it looks good. OK. I was missing the description. I'll add it. Best Regards, Chanwoo Choi