public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/rockchip: vop: Don't reject empty modesets
@ 2016-03-18 11:22 Tomeu Vizoso
  2016-03-28  6:40 ` Mark yao
  0 siblings, 1 reply; 2+ messages in thread
From: Tomeu Vizoso @ 2016-03-18 11:22 UTC (permalink / raw)
  To: linux-kernel
  Cc: Tomeu Vizoso, Mark Yao, David Airlie, Heiko Stuebner, dri-devel,
	linux-arm-kernel, linux-rockchip

So that when DRM_IOCTL_MODE_SETCRTC is called without a FB nor mode, the
CRTC gets disabled.

Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Link: http://lkml.kernel.org/g/CAAObsKAv+05ih5U+=4kic_NsjGMhfxYheHR8xXXmacZs+p5SHw@mail.gmail.com
---
 drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
index fd370548d7d7..5e57f5b2e4b0 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
@@ -885,9 +885,6 @@ static bool vop_crtc_mode_fixup(struct drm_crtc *crtc,
 {
 	struct vop *vop = to_vop(crtc);
 
-	if (adjusted_mode->htotal == 0 || adjusted_mode->vtotal == 0)
-		return false;
-
 	adjusted_mode->clock =
 		clk_round_rate(vop->dclk, mode->clock * 1000) / 1000;
 
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/rockchip: vop: Don't reject empty modesets
  2016-03-18 11:22 [PATCH] drm/rockchip: vop: Don't reject empty modesets Tomeu Vizoso
@ 2016-03-28  6:40 ` Mark yao
  0 siblings, 0 replies; 2+ messages in thread
From: Mark yao @ 2016-03-28  6:40 UTC (permalink / raw)
  To: Tomeu Vizoso, linux-kernel
  Cc: David Airlie, Heiko Stuebner, dri-devel, linux-arm-kernel,
	linux-rockchip

On 2016年03月18日 19:22, Tomeu Vizoso wrote:
> So that when DRM_IOCTL_MODE_SETCRTC is called without a FB nor mode, the
> CRTC gets disabled.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Link: http://lkml.kernel.org/g/CAAObsKAv+05ih5U+=4kic_NsjGMhfxYheHR8xXXmacZs+p5SHw@mail.gmail.com
> ---
>   drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> index fd370548d7d7..5e57f5b2e4b0 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -885,9 +885,6 @@ static bool vop_crtc_mode_fixup(struct drm_crtc *crtc,
>   {
>   	struct vop *vop = to_vop(crtc);
>   
> -	if (adjusted_mode->htotal == 0 || adjusted_mode->vtotal == 0)
> -		return false;
> -
>   	adjusted_mode->clock =
>   		clk_round_rate(vop->dclk, mode->clock * 1000) / 1000;
>   
Applied to my drm-fixes, Thanks.

-- 
Mark Yao

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-03-28  6:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-18 11:22 [PATCH] drm/rockchip: vop: Don't reject empty modesets Tomeu Vizoso
2016-03-28  6:40 ` Mark yao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox