From: Mark yao <mark.yao@rock-chips.com>
To: Douglas Anderson <dianders@chromium.org>,
David Airlie <airlied@linux.ie>,
linux@arm.linux.org.uk, Heiko Stuebner <heiko@sntech.de>
Cc: Daniel Kurtz <djkurtz@chromium.org>,
linux-rockchip@lists.infradead.org, john@keeping.me.uk,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] drm/rockchip: dw_hdmi: Call drm_encoder_cleanup() in error path
Date: Mon, 28 Mar 2016 14:45:02 +0800 [thread overview]
Message-ID: <56F8D2EE.4080004@rock-chips.com> (raw)
In-Reply-To: <1457388054-23077-1-git-send-email-dianders@chromium.org>
On 2016年03月08日 06:00, Douglas Anderson wrote:
> The drm_encoder_cleanup() was missing both from the error path of
> dw_hdmi_rockchip_bind(). This caused a crash when slub_debug was
> enabled and we ended up deferring probe of HDMI at boot.
>
> This call isn't needed from unbind() because if dw_hdmi_bind() returns
> no error then it takes over the job of freeing the encoder (in
> dw_hdmi_unbind).
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Hi Douglas
it seems has no doubt on these patch, and it works on my board, So I'd
like to apply following three patches.
[PATCH v2 1/5] drm/rockchip: dw_hdmi: Call drm_encoder_cleanup() in
error path
[PATCH v2 3/5] drm/rockchip: vop: Fix vop crtc cleanup
[PATCH v2 4/5] drm/rockchip: dw_hdmi: Don't call platform_set_drvdata()
Thanks for your fixes.
-- Ｍark Yao
prev parent reply other threads:[~2016-03-28 6:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 22:00 [PATCH v2 1/5] drm/rockchip: dw_hdmi: Call drm_encoder_cleanup() in error path Douglas Anderson
2016-03-07 22:00 ` [PATCH v2 2/5] drm/imx: " Douglas Anderson
2016-03-28 15:14 ` Doug Anderson
2016-03-30 13:35 ` Philipp Zabel
2016-03-07 22:00 ` [PATCH v2 3/5] drm/rockchip: vop: Fix vop crtc cleanup Douglas Anderson
2016-03-07 22:00 ` [PATCH v2 4/5] drm/rockchip: dw_hdmi: Don't call platform_set_drvdata() Douglas Anderson
2016-03-07 22:00 ` [PATCH v2 5/5] drm/imx: " Douglas Anderson
2016-03-28 6:45 ` Mark yao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F8D2EE.4080004@rock-chips.com \
--to=mark.yao@rock-chips.com \
--cc=airlied@linux.ie \
--cc=dianders@chromium.org \
--cc=djkurtz@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=john@keeping.me.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox