From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754882AbcC1KIn (ORCPT ); Mon, 28 Mar 2016 06:08:43 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:44647 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753999AbcC1KIk (ORCPT ); Mon, 28 Mar 2016 06:08:40 -0400 Subject: Re: [PATCH 1/1] iio: accel: bmc150: remove unused definition To: Irina Tirdea , linux-iio@vger.kernel.org References: <1458810056-24236-1-git-send-email-irina.tirdea@intel.com> Cc: linux-kernel@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Markus Pargmann From: Jonathan Cameron Message-ID: <56F902A6.9020307@kernel.org> Date: Mon, 28 Mar 2016 11:08:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1458810056-24236-1-git-send-email-irina.tirdea@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/03/16 09:00, Irina Tirdea wrote: > bmc150_i2c_regmap_conf is defined in bmc150-accel-core.c, but > never used here. The definition is needed in bmc150-accel-i2c.c, > where it is again defined. > > Remove the unnecessary definition of bmc150_i2c_regmap_conf from > bmc150-accel-core.c and update the one from bmc150-accel-i2c.c > to contain all fields. > > Signed-off-by: Irina Tirdea Silly question. Why isn't it shared between the i2c and spi drivers? Looks to be the same in both cases (as we'd expect from regmap most of the time!). I think it would be better to share it. Jonathan > --- > drivers/iio/accel/bmc150-accel-core.c | 6 ------ > drivers/iio/accel/bmc150-accel-i2c.c | 1 + > 2 files changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/iio/accel/bmc150-accel-core.c b/drivers/iio/accel/bmc150-accel-core.c > index c73331f7..feff894 100644 > --- a/drivers/iio/accel/bmc150-accel-core.c > +++ b/drivers/iio/accel/bmc150-accel-core.c > @@ -246,12 +246,6 @@ static const struct { > {500000, BMC150_ACCEL_SLEEP_500_MS}, > {1000000, BMC150_ACCEL_SLEEP_1_SEC} }; > > -static const struct regmap_config bmc150_i2c_regmap_conf = { > - .reg_bits = 8, > - .val_bits = 8, > - .max_register = 0x3f, > -}; > - > static int bmc150_accel_set_mode(struct bmc150_accel_data *data, > enum bmc150_power_modes mode, > int dur_us) > diff --git a/drivers/iio/accel/bmc150-accel-i2c.c b/drivers/iio/accel/bmc150-accel-i2c.c > index b41404b..f0969fe 100644 > --- a/drivers/iio/accel/bmc150-accel-i2c.c > +++ b/drivers/iio/accel/bmc150-accel-i2c.c > @@ -31,6 +31,7 @@ > static const struct regmap_config bmc150_i2c_regmap_conf = { > .reg_bits = 8, > .val_bits = 8, > + .max_register = 0x3f, > }; > > static int bmc150_accel_probe(struct i2c_client *client, >