From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756221AbcC2HqI (ORCPT ); Tue, 29 Mar 2016 03:46:08 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:13989 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752699AbcC2HqE (ORCPT ); Tue, 29 Mar 2016 03:46:04 -0400 X-AuditID: cbfec7f5-f792a6d000001302-e3-56fa32b8a893 Subject: Re: Applied "regulator: s2mps11: Fix invalid selector mask and voltages for buck9" to the regulator tree To: Mark Brown , Javier Martinez Canillas , stable@vger.kernel.org References: Cc: linux-kernel@vger.kernel.org From: Krzysztof Kozlowski Message-id: <56FA32B4.4010606@samsung.com> Date: Tue, 29 Mar 2016 16:45:56 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJLMWRmVeSWpSXmKPExsVy+t/xy7o7jH6FGdycImgx9eETNos3b9cw Wbx+YWhxedccNosFGx8xOrB6bFrVyeaxpf8uu0ffllWMHp83yQWwRHHZpKTmZJalFunbJXBl 7Hz2n7XggmjF52u/GRsYDwh2MXJySAiYSMx4fpYJwhaTuHBvPVsXIxeHkMBSRonXcyYxQzhP GSU+Hl3HClIlLFAqMWvvIrAOEYECiUn3mthAbCEBLYnlzR/A4swCChK/7m0Cq2cTMJbYvHwJ WA0vUM26U7dYuhg5OFgEVCWWN9SChEUFIiSezD3JCFEiKPFj8j0WEJtTQFuid+ZEVpByZgE9 ifsXtSCmy0tsXvOWeQKjwCwkHbMQqmYhqVrAyLyKUTS1NLmgOCk910ivODG3uDQvXS85P3cT IySAv+5gXHrM6hCjAAejEg9vxKKfYUKsiWXFlbmHGCU4mJVEeKvEf4UJ8aYkVlalFuXHF5Xm pBYfYpTmYFES5525632IkEB6YklqdmpqQWoRTJaJg1OqgXEFgxHL7D13lsUosih0nZOX1/pS qOVoZ7ie86u5cGPbcuWo05H7rtnVLeFxFbtz81oQw9/mN/N5otjm3v5VkdXe2vb4U//c23ME zkVG99zUXKMRMlfWxP/MIR5Hrq9Jj66y3uLOTtAVuqpis0REdsHNlZffqUy4cpH9p36CikBY dd/B7Jc/opVYijMSDbWYi4oTAV1OHG5cAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.03.2016 16:39, Mark Brown wrote: > The patch > > regulator: s2mps11: Fix invalid selector mask and voltages for buck9 > > has been applied to the regulator tree at > > git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git > > All being well this means that it will be integrated into the linux-next > tree (usually sometime in the next 24 hours) and sent to Linus during > the next merge window (or sooner if it is a bug fix), however if > problems are discovered then the patch may be dropped or reverted. > > You may get further e-mails resulting from automated or manual testing > and review of the tree, please engage with people reporting problems and > send followup patches addressing any issues that are reported if needed. > > If any updates are required or you are submitting further changes they > should be sent as incremental updates against current git, existing > patches will not be replaced. > > Please add any relevant lists and maintainers to the CCs when replying > to this mail. > > Thanks, > Mark > >>>From 3b672623079bb3e5685b8549e514f2dfaa564406 Mon Sep 17 00:00:00 2001 > From: Krzysztof Kozlowski > Date: Mon, 28 Mar 2016 13:09:56 +0900 > Subject: [PATCH] regulator: s2mps11: Fix invalid selector mask and voltages > for buck9 > > The buck9 regulator of S2MPS11 PMIC had incorrect vsel_mask (0xff > instead of 0x1f) thus reading entire register as buck9's voltage. This > effectively caused regulator core to interpret values as higher voltages > than they were and then to set real voltage much lower than intended. > > The buck9 provides power to other regulators, including LDO13 > and LDO19 which supply the MMC2 (SD card). On Odroid XU3/XU4 the lower > voltage caused SD card detection errors on Odroid XU3/XU4: > mmc1: card never left busy state > mmc1: error -110 whilst initialising SD card > > During driver probe the regulator core was checking whether initial > voltage matches the constraints. With incorrect vsel_mask of 0xff and > default value of 0x50, the core interpreted this as 5 V which is outside > of constraints (3-3.775 V). Then the regulator core was adjusting the > voltage to match the constraints. With incorrect vsel_mask this new > voltage mapped to a vere low voltage in the driver. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Javier Martinez Canillas > Tested-by: Javier Martinez Canillas > Signed-off-by: Mark Brown > Cc: Hi Mark, Hmm, the "Fixes" tag disappeared. I think it might be useful for stable backport. Best regards, Krzysztof