* [PATCH] bpf: doc: "neg" opcode has no operands
@ 2016-03-28 21:56 Kees Cook
2016-03-29 0:32 ` Alexei Starovoitov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Kees Cook @ 2016-03-28 21:56 UTC (permalink / raw)
To: Daniel Borkmann
Cc: Alexei Starovoitov, David S. Miller, Jonathan Corbet, Yang Shi,
Dave Anderson, linux-kernel, linux-doc
From: Dave Anderson <danderson@google.com>
Fixes a copy-paste-o in the BPF opcode table: "neg" takes no arguments
and thus has no addressing modes.
Signed-off-by: Dave Anderson <danderson@google.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
---
Documentation/networking/filter.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/networking/filter.txt b/Documentation/networking/filter.txt
index 96da119a47e7..11f67f181d39 100644
--- a/Documentation/networking/filter.txt
+++ b/Documentation/networking/filter.txt
@@ -230,7 +230,7 @@ opcodes as defined in linux/filter.h stand for:
mul 0, 4 A * <x>
div 0, 4 A / <x>
mod 0, 4 A % <x>
- neg 0, 4 !A
+ neg !A
and 0, 4 A & <x>
or 0, 4 A | <x>
xor 0, 4 A ^ <x>
--
2.6.3
--
Kees Cook
Chrome OS & Brillo Security
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] bpf: doc: "neg" opcode has no operands
2016-03-28 21:56 [PATCH] bpf: doc: "neg" opcode has no operands Kees Cook
@ 2016-03-29 0:32 ` Alexei Starovoitov
2016-03-29 7:57 ` Daniel Borkmann
2016-03-31 6:32 ` Jonathan Corbet
2 siblings, 0 replies; 4+ messages in thread
From: Alexei Starovoitov @ 2016-03-29 0:32 UTC (permalink / raw)
To: Kees Cook
Cc: Daniel Borkmann, Alexei Starovoitov, David S. Miller,
Jonathan Corbet, Yang Shi, Dave Anderson, linux-kernel, linux-doc
On Mon, Mar 28, 2016 at 02:56:47PM -0700, Kees Cook wrote:
> From: Dave Anderson <danderson@google.com>
>
> Fixes a copy-paste-o in the BPF opcode table: "neg" takes no arguments
> and thus has no addressing modes.
>
> Signed-off-by: Dave Anderson <danderson@google.com>
> Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: Alexei Starovoitov <ast@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bpf: doc: "neg" opcode has no operands
2016-03-28 21:56 [PATCH] bpf: doc: "neg" opcode has no operands Kees Cook
2016-03-29 0:32 ` Alexei Starovoitov
@ 2016-03-29 7:57 ` Daniel Borkmann
2016-03-31 6:32 ` Jonathan Corbet
2 siblings, 0 replies; 4+ messages in thread
From: Daniel Borkmann @ 2016-03-29 7:57 UTC (permalink / raw)
To: Kees Cook
Cc: Alexei Starovoitov, David S. Miller, Jonathan Corbet, Yang Shi,
Dave Anderson, linux-kernel, linux-doc
On 03/28/2016 11:56 PM, Kees Cook wrote:
> From: Dave Anderson <danderson@google.com>
>
> Fixes a copy-paste-o in the BPF opcode table: "neg" takes no arguments
> and thus has no addressing modes.
>
> Signed-off-by: Dave Anderson <danderson@google.com>
> Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bpf: doc: "neg" opcode has no operands
2016-03-28 21:56 [PATCH] bpf: doc: "neg" opcode has no operands Kees Cook
2016-03-29 0:32 ` Alexei Starovoitov
2016-03-29 7:57 ` Daniel Borkmann
@ 2016-03-31 6:32 ` Jonathan Corbet
2 siblings, 0 replies; 4+ messages in thread
From: Jonathan Corbet @ 2016-03-31 6:32 UTC (permalink / raw)
To: Kees Cook
Cc: Daniel Borkmann, Alexei Starovoitov, David S. Miller, Yang Shi,
Dave Anderson, linux-kernel, linux-doc
On Mon, 28 Mar 2016 14:56:47 -0700
Kees Cook <keescook@chromium.org> wrote:
> From: Dave Anderson <danderson@google.com>
>
> Fixes a copy-paste-o in the BPF opcode table: "neg" takes no arguments
> and thus has no addressing modes.
I've applied this to the docs tree, thanks.
jon
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-31 6:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-28 21:56 [PATCH] bpf: doc: "neg" opcode has no operands Kees Cook
2016-03-29 0:32 ` Alexei Starovoitov
2016-03-29 7:57 ` Daniel Borkmann
2016-03-31 6:32 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox