From: Ian Abbott <abbotti@mev.co.uk>
To: Aniket Sharma <badbuddha91@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: Fix 'unsigned' warning style
Date: Tue, 29 Mar 2016 10:36:21 +0100 [thread overview]
Message-ID: <56FA4C95.4030207@mev.co.uk> (raw)
In-Reply-To: <20160327175219.GA27001@ubuntu>
On 27/03/16 18:52, Aniket Sharma wrote:
> This patch fixes the checkpatch.pl warning:
>
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> + unsigned runflags;
>
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> +struct comedi_device *comedi_dev_get_from_minor(unsigned minor);
>
> Signed-off-by: Aniket Sharma <badbuddha91@gmail.com>
> ---
> drivers/staging/comedi/comedidev.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
> index 1158072..dcb6376 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -173,7 +173,7 @@ struct comedi_subdevice {
>
> void *lock;
> void *busy;
> - unsigned runflags;
> + unsigned int runflags;
> spinlock_t spin_lock; /* generic spin-lock for COMEDI and drivers */
>
> unsigned int io_bits;
> @@ -566,7 +566,7 @@ struct comedi_device {
>
> void comedi_event(struct comedi_device *dev, struct comedi_subdevice *s);
>
> -struct comedi_device *comedi_dev_get_from_minor(unsigned minor);
> +struct comedi_device *comedi_dev_get_from_minor(unsigned int minor);
> int comedi_dev_put(struct comedi_device *dev);
>
> bool comedi_is_subdevice_running(struct comedi_subdevice *s);
>
Thanks!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
prev parent reply other threads:[~2016-03-29 9:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-27 17:52 [PATCH] Staging: comedi: Fix 'unsigned' warning style Aniket Sharma
2016-03-29 9:36 ` Ian Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FA4C95.4030207@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=badbuddha91@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox