From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756527AbcC2Jg1 (ORCPT ); Tue, 29 Mar 2016 05:36:27 -0400 Received: from smtp121.iad3a.emailsrvr.com ([173.203.187.121]:44035 "EHLO smtp121.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751122AbcC2JgY (ORCPT ); Tue, 29 Mar 2016 05:36:24 -0400 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH] Staging: comedi: Fix 'unsigned' warning style To: Aniket Sharma References: <20160327175219.GA27001@ubuntu> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Ian Abbott Message-ID: <56FA4C95.4030207@mev.co.uk> Date: Tue, 29 Mar 2016 10:36:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160327175219.GA27001@ubuntu> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/03/16 18:52, Aniket Sharma wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > + unsigned runflags; > > WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > +struct comedi_device *comedi_dev_get_from_minor(unsigned minor); > > Signed-off-by: Aniket Sharma > --- > drivers/staging/comedi/comedidev.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h > index 1158072..dcb6376 100644 > --- a/drivers/staging/comedi/comedidev.h > +++ b/drivers/staging/comedi/comedidev.h > @@ -173,7 +173,7 @@ struct comedi_subdevice { > > void *lock; > void *busy; > - unsigned runflags; > + unsigned int runflags; > spinlock_t spin_lock; /* generic spin-lock for COMEDI and drivers */ > > unsigned int io_bits; > @@ -566,7 +566,7 @@ struct comedi_device { > > void comedi_event(struct comedi_device *dev, struct comedi_subdevice *s); > > -struct comedi_device *comedi_dev_get_from_minor(unsigned minor); > +struct comedi_device *comedi_dev_get_from_minor(unsigned int minor); > int comedi_dev_put(struct comedi_device *dev); > > bool comedi_is_subdevice_running(struct comedi_subdevice *s); > Thanks! Reviewed-by: Ian Abbott -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-