Re: [PATCH 1/3] ARM: at91: use chipid device for soc detection

Alexandre Belloni
2016-03-23T13:47:53Z

On 23/03/2016 at 12:22:49 +0100, Nicolas Ferre wrote :
> Le 18/03/2016 11:34, Alexandre Belloni a écrit :
> > On 18/03/2016 at 08:21:19 +0100, Ludovic Desroches wrote :
> >> So far, the CIDR and EXID registers were in the DBGU interface. This device
> >> has disappeared with the SAMA5D2 family. These registers are exposed
> >> through a new device called chipid.
> >>
> >> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> >> [nicolas.ferre@atmel.com: remove useless warnings]
> > Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> >
> >> ---
> >> .../devicetree/bindings/arm/atmel-at91.txt | 4 ++
> >> arch/arm/mach-at91/soc.c | 81 +++++++++++++++++-----
>
> We may need to split this patch in 2 for going through separate arm-soc
> branches: what do you think Alexandre?
>

I think the patch can go in as it is now, the documentation being in
line with the code.

--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering