From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Arnd Bergmann <arnd@arndb.de>,
Ludovic Desroches <ludovic.desroches@atmel.com>
Cc: <alexandre.belloni@free-electrons.com>, <plagnioj@jcrosoft.com>,
<boris.brezillon@free-electrons.com>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] ARM: at91: use chipid device for soc detection
Date: Tue, 29 Mar 2016 16:04:31 +0200 [thread overview]
Message-ID: <56FA8B6F.4010008@atmel.com> (raw)
In-Reply-To: <55618572.U3p4crGV1Y@wuerfel>
Le 29/03/2016 15:55, Arnd Bergmann a écrit :
> On Friday 18 March 2016 08:21:19 Ludovic Desroches wrote:
>> -struct soc_device * __init at91_soc_init(const struct at91_soc *socs)
>> +int __init at91_get_cidr_exid_from_dbgu(u32 *cidr, u32 *exid)
>> {
>
>
>> +
>> +int __init at91_get_cidr_exid_from_chipid(u32 *cidr, u32 *exid)
>> +{
>>
>
> These should both be 'static', right?
Absolutely. I modify this right now and repost a patch.
Bye,
--
Nicolas Ferre
next prev parent reply other threads:[~2016-03-29 14:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 7:21 [PATCH 1/3] ARM: at91: use chipid device for soc detection Ludovic Desroches
2016-03-18 7:21 ` [PATCH 2/3] ARM: at91/soc: reference the whole sama5d2 family Ludovic Desroches
2016-03-18 10:34 ` Alexandre Belloni
2016-03-18 7:21 ` [PATCH 3/3] ARM: at91/dt: sama5d2: add chipid node Ludovic Desroches
2016-03-18 10:34 ` Alexandre Belloni
2016-03-18 10:34 ` [PATCH 1/3] ARM: at91: use chipid device for soc detection Alexandre Belloni
2016-03-23 11:22 ` Nicolas Ferre
2016-03-23 13:47 ` Alexandre Belloni
2016-03-29 13:53 ` Nicolas Ferre
2016-03-20 0:45 ` Rob Herring
2016-03-29 13:55 ` Arnd Bergmann
2016-03-29 14:04 ` Nicolas Ferre [this message]
2016-03-29 14:10 ` [PATCH v2 " Nicolas Ferre
2016-03-29 14:30 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FA8B6F.4010008@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=arnd@arndb.de \
--cc=boris.brezillon@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox