From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Viresh Kumar <viresh.kumar@linaro.org>, Arnd Bergmann <arnd@arndb.de>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Rafael Wysocki" <rjw@rjwysocki.net>,
"Arnd Bergmann" <arnd.bergmann@linaro.org>,
"Kukjin Kim" <kgene@kernel.org>,
"Kukjin Kim" <kgene.kim@samsung.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Feng Xiao" <xf@rock-chips.com>,
"Matthew McClintock" <mmcclint@codeaurora.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
"Linaro Kernel Mailman List" <linaro-kernel@lists.linaro.org>
Subject: Re: [PATCH V2 3/3] cpufreq: exynos: Use generic platdev driver
Date: Wed, 30 Mar 2016 08:46:36 +0900 [thread overview]
Message-ID: <56FB13DC.2090902@samsung.com> (raw)
In-Reply-To: <CAKohpomQ9=YK79o0fqHqZ7xexHv5EMJSPx+4KrT0RxeMh+hwWg@mail.gmail.com>
On 30.03.2016 00:22, Viresh Kumar wrote:
> On 29 March 2016 at 20:34, Arnd Bergmann <arnd@arndb.de> wrote:
>> On Tuesday 29 March 2016 12:09:49 Viresh Kumar wrote:
>>> -static void __init exynos_cpufreq_init(void)
>>> -{
>>> - struct device_node *root = of_find_node_by_path("/");
>>> - const struct of_device_id *match;
>>> -
>>> - match = of_match_node(exynos_cpufreq_matches, root);
>>> - if (!match) {
>>> - platform_device_register_simple("exynos-cpufreq", -1, NULL, 0);
>>> - return;
>>> - }
>>> -
>>> - platform_device_register_simple(match->data, -1, NULL, 0);
>>> -}
>>
>> How is the "exynos-cpufreq" case handled now? Is that no longer used now?
>> I assume the patch is correct based on Krzysztof's review, but it might be
>> good to explain this better.
>
> That's stale code, the driver got removed some time back.
Yeah, that's old driver, no longer existing. It makes sense to split the
patch - first remove the stale exynos-cpufreq and then move cpufreq-dt.
This would help avoid confusion when grepping through the history.
Best regards,
Krzysztof
prev parent reply other threads:[~2016-03-29 23:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1459233524.git.viresh.kumar@linaro.org>
2016-03-29 6:39 ` [PATCH V1 Resend 1/3] cpufreq: dt: Include types.h from cpufreq-dt.h Viresh Kumar
2016-03-29 6:39 ` [PATCH V1 Resend 2/3] cpufreq: dt: Add generic platform-device creation support Viresh Kumar
2016-03-29 15:14 ` Arnd Bergmann
2016-03-29 16:36 ` Viresh Kumar
2016-03-29 19:45 ` Arnd Bergmann
2016-03-30 3:22 ` Viresh Kumar
2016-03-30 7:53 ` Arnd Bergmann
2016-04-01 10:23 ` Viresh Kumar
2016-04-01 12:30 ` Mason
2016-04-01 12:52 ` Viresh Kumar
2016-04-01 14:15 ` Rob Herring
2016-04-07 8:30 ` Viresh Kumar
2016-04-18 21:00 ` Arnd Bergmann
2016-03-29 16:42 ` Viresh Kumar
2016-03-29 19:46 ` Arnd Bergmann
2016-03-29 6:39 ` [PATCH V2 3/3] cpufreq: exynos: Use generic platdev driver Viresh Kumar
2016-03-29 15:04 ` Arnd Bergmann
2016-03-29 15:22 ` Viresh Kumar
2016-03-29 23:46 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FB13DC.2090902@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=arnd.bergmann@linaro.org \
--cc=arnd@arndb.de \
--cc=heiko@sntech.de \
--cc=kgene.kim@samsung.com \
--cc=kgene@kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mmcclint@codeaurora.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
--cc=xf@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox