From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>, linux-kernel@vger.kernel.org
Subject: Re: [RESEND] phy: Fix build error of missing devm_ioremap_resource on UM
Date: Wed, 30 Mar 2016 17:23:43 +0900 [thread overview]
Message-ID: <56FB8D0F.1010108@samsung.com> (raw)
In-Reply-To: <20160330081036.GC3323@x1>
On 30.03.2016 17:10, Lee Jones wrote:
> On Wed, 30 Mar 2016, Lee Jones wrote:
>
>> On Wed, 30 Mar 2016, Krzysztof Kozlowski wrote:
>>
>>> The devres.o gets linked if HAS_IOMEM is present so on ARCH=um
>>> allyesconfig (COMPILE_TEST) failed with:
>>>
>>> drivers/built-in.o: In function `omap_control_phy_probe':
>>> phy-omap-control.c:(.text+0x16db): undefined reference to `devm_ioremap_resource'
>>> drivers/built-in.o: In function `cygnus_pcie_phy_probe':
>>> phy-bcm-cygnus-pcie.c:(.text+0x1bfa): undefined reference to `devm_ioremap_resource'
>>>
>>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>> ---
>>> drivers/phy/Kconfig | 2 ++
>>> 1 file changed, 2 insertions(+)
>>
>> Holding off on this until the discussion reaches some kind of
>> consensus.
>
> FYI: https://lkml.org/lkml/2016/3/29/716
Yeah, I saw it today.
But this is a little bit different. It is not caused by selecting
MFD_SYSCON but because of unlinked devres.o (which is linked by HAS_IOMEM).
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-03-30 8:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 0:48 [RESEND] phy: Fix build error of missing devm_ioremap_resource on UM Krzysztof Kozlowski
2016-03-30 8:08 ` Lee Jones
2016-03-30 8:10 ` Lee Jones
2016-03-30 8:23 ` Krzysztof Kozlowski [this message]
2016-03-30 12:01 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FB8D0F.1010108@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=kishon@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox