From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932780AbcC3IYB (ORCPT ); Wed, 30 Mar 2016 04:24:01 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:9517 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932594AbcC3IX6 (ORCPT ); Wed, 30 Mar 2016 04:23:58 -0400 X-AuditID: cbfec7f5-f792a6d000001302-f5-56fb8d1af529 Subject: Re: [RESEND] phy: Fix build error of missing devm_ioremap_resource on UM To: Lee Jones References: <1459298921-20410-1-git-send-email-k.kozlowski@samsung.com> <20160330080856.GB3323@x1> <20160330081036.GC3323@x1> Cc: Kishon Vijay Abraham I , linux-kernel@vger.kernel.org From: Krzysztof Kozlowski Message-id: <56FB8D0F.1010108@samsung.com> Date: Wed, 30 Mar 2016 17:23:43 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: <20160330081036.GC3323@x1> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCLMWRmVeSWpSXmKPExsVy+t/xK7pSvb/DDH5MlLJ4/cLQ4sLTHjaL +1+PMlpc3jWHzYHF4861PWwefVtWMXocv7GdyePzJrkAligum5TUnMyy1CJ9uwSujJ5dh5kK pnFUNK65z9rA+Jyti5GTQ0LARGLxjV9QtpjEhXvrgWwuDiGBpYwS2xsboZynjBK/919nB6kS FgiWuLF6JksXIweHiICKxLk35iBhIYF6iXV3FzCC2MwCHhKHZveAlbMJGEtsXr4EbAGvgJZE x+2tzCA2i4CqxPVPM8HqRQUiJJ7MPckIUSMo8WPyPRYQm1NAXaL/zgSwVcxA9pQpuRDj5SU2 r3nLPIFRYBaSjlkIVbOQVC1gZF7FKJpamlxQnJSea6RXnJhbXJqXrpecn7uJERK2X3cwLj1m dYhRgINRiYd3g/TvMCHWxLLiytxDjBIczEoivD49QCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8 M3e9DxESSE8sSc1OTS1ILYLJMnFwSjUwxk+fdOGAnMlnuXUz2jQNP07V4ShNT7k5Q0THTsX7 ebfdFoXTAWuW+utHFU9sSw188rA2Zlq+ugt/TNL/lR6NJkG9DDsVQtze7qtq3X+3WVbrdsgN dfs3E8/H3n3IK2h5/em1IObaypSH0a+MpOKLz2f8YOVP35ZnHytm8ShReeY8ztS1SSlKLMUZ iYZazEXFiQAUbJn3VwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30.03.2016 17:10, Lee Jones wrote: > On Wed, 30 Mar 2016, Lee Jones wrote: > >> On Wed, 30 Mar 2016, Krzysztof Kozlowski wrote: >> >>> The devres.o gets linked if HAS_IOMEM is present so on ARCH=um >>> allyesconfig (COMPILE_TEST) failed with: >>> >>> drivers/built-in.o: In function `omap_control_phy_probe': >>> phy-omap-control.c:(.text+0x16db): undefined reference to `devm_ioremap_resource' >>> drivers/built-in.o: In function `cygnus_pcie_phy_probe': >>> phy-bcm-cygnus-pcie.c:(.text+0x1bfa): undefined reference to `devm_ioremap_resource' >>> >>> Signed-off-by: Krzysztof Kozlowski >>> --- >>> drivers/phy/Kconfig | 2 ++ >>> 1 file changed, 2 insertions(+) >> >> Holding off on this until the discussion reaches some kind of >> consensus. > > FYI: https://lkml.org/lkml/2016/3/29/716 Yeah, I saw it today. But this is a little bit different. It is not caused by selecting MFD_SYSCON but because of unlinked devres.o (which is linked by HAS_IOMEM). Best regards, Krzysztof