From: Michal Marek <mmarek@suse.cz>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Al Viro <viro@zeniv.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Jan Beulich <JBeulich@suse.com>,
linux-kbuild <linux-kbuild@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] kconfig changes for v4.6-rc1
Date: Wed, 30 Mar 2016 15:29:39 +0200 [thread overview]
Message-ID: <56FBD4C3.5090701@suse.cz> (raw)
In-Reply-To: <CAMuHMdX1W9dg4oeAH0Qw5MNFXBO-joHc_=BKLcBgruT0h9a9kg@mail.gmail.com>
On 2016-03-25 10:03, Geert Uytterhoeven wrote:
> On Fri, Mar 25, 2016 at 9:54 AM, Geert Uytterhoeven
>>> Al Viro (1):
>>> unbreak allmodconfig KCONFIG_ALLCONFIG=...
>>
>> I can now indeed drop the
>>
>> CONFIG_MODULES=y
>>
>> line from my
>>
>> allmod.config
>>
>> However, this fix has the side-effect of enabling CONFIG_MODULES silently for
>>
>> make allyesconfig KCONFIG_ALLCONFIG=1
>>
>> Adding an explicit
>>
>> CONFIG_MODULES=n
>>
>> to the allyes.config file fixes that.
>>
>> IMHO CONFIG_MODULES should default to y when using allmodconfig, and
>> default to n when using allyesconfig.
>
> Hmm, it seems plain "make allyesconfig" also enables CONFIG_MODULES, and
> makes many options modular. Is that intentional, especially the latter?
allyesconfig builds everything into the kernel, so why exclude the
module loader. And there are a few modules with a 'depends on m'
statement, either because this is test code in samples/ which is not
even considered when linking the kernel, or there is some "issue" when
the code is built-in. The statement might also be completely bogus, but
that's not a job of allyesconfig to decide.
Michal
prev parent reply other threads:[~2016-03-30 13:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 20:51 [GIT PULL] kconfig changes for v4.6-rc1 Michal Marek
2016-03-25 8:54 ` Geert Uytterhoeven
2016-03-25 9:03 ` Geert Uytterhoeven
2016-03-30 13:29 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FBD4C3.5090701@suse.cz \
--to=mmarek@suse.cz \
--cc=JBeulich@suse.com \
--cc=geert@linux-m68k.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox