public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Georgi Djakov <georgi.djakov@linaro.org>
To: Stephen Boyd <stephen.boyd@linaro.org>, Mark Brown <broonie@kernel.org>
Cc: linux-arm@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org,
	David Collins <collinsd@codeaurora.org>
Subject: Re: [PATCH] regulator: qcom_spmi: Add slewing delays for all SMPS types
Date: Wed, 30 Mar 2016 17:36:11 +0300	[thread overview]
Message-ID: <56FBE45B.4030709@linaro.org> (raw)
In-Reply-To: <1459292320-1996-1-git-send-email-stephen.boyd@linaro.org>

On 03/30/2016 01:58 AM, Stephen Boyd wrote:
> Only the FT SMPS type regulators have slewing supported in the
> driver, but all types of SMPS regulators need the same support.
> The only difference is that some SMPS regulators don't have a
> step size and the step delay is typically 20, not 8. Luckily, the
> step size reads as 0 for the non-FT types, so we can always read
> that, but we need to detect which type of regulator we're using
> to figure out what step delay to use. Make these minor
> adjustments to the slew rate calculations and add support for the
> delay function to the appropriate regulator ops.
> 
> Reported-by: Georgi Djakov <georgi.djakov@linaro.org>
> Cc: David Collins <collinsd@codeaurora.org>
> Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>

Thanks for the patch! I have verified it by applying this one
on top: https://lkml.org/lkml/2016/3/30/381

Tested-by: Georgi Djakov <georgi.djakov@linaro.org>

BR,
Georgi

  parent reply	other threads:[~2016-03-30 14:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-29 22:58 [PATCH] regulator: qcom_spmi: Add slewing delays for all SMPS types Stephen Boyd
2016-03-29 23:09 ` Mark Brown
2016-03-30 14:36 ` Georgi Djakov [this message]
2016-03-30 18:09   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56FBE45B.4030709@linaro.org \
    --to=georgi.djakov@linaro.org \
    --cc=broonie@kernel.org \
    --cc=collinsd@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-arm@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stephen.boyd@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox