From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752330AbcCaA72 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 30 Mar 2016 20:59:28 -0400
Received: from szxga03-in.huawei.com ([119.145.14.66]:2734 "EHLO
	szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750803AbcCaA71 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 30 Mar 2016 20:59:27 -0400
Reply-To: <qiujiang@huawei.com>
Subject: Re: [PATCH v6 2/2] gpio: dwapb: add gpio-signaled acpi event support
References: <1458959496-57455-1-git-send-email-qiujiang@huawei.com>
 <1458959496-57455-3-git-send-email-qiujiang@huawei.com>
 <CAHp75VcRkwDm60b7PTJmYmPVX7iNoLFL_pcx5qUK8=E7zMyKtw@mail.gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
CC: Linus Walleij <linus.walleij@linaro.org>,
        Alexandre Courbot <gnurou@gmail.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        "Alan Tull" <delicious.quinoa@gmail.com>,
        Jamie Iles <jamie@jamieiles.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        <linuxarm@huawei.com>, <haifeng.wei@huawei.com>,
        <charles.chenxin@huawei.com>
From: Jiang Qiu <qiujiang@huawei.com>
Message-ID: <56FC7656.1020900@huawei.com>
Date: Thu, 31 Mar 2016 08:59:02 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <CAHp75VcRkwDm60b7PTJmYmPVX7iNoLFL_pcx5qUK8=E7zMyKtw@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.74.160.152]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020202.56FC7660.00B8,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-05-26 15:14:31,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 37feebd4984fe5fb2c6133d2d8626f4c
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

在 2016/3/30 19:41, Andy Shevchenko 写道:
> On Sat, Mar 26, 2016 at 4:31 AM, qiujiang <qiujiang@huawei.com> wrote:
>> This patch adds gpio-signaled acpi event support. It is used for
>> power button on hisilicon D02 board, an arm64 platform.
> 
> Yes, looks good, my tag stays.
> 
>> @@ -502,10 +509,17 @@ dwapb_gpio_get_pdata(struct device *dev)
>>                         }
>>                 }
>>
>> +               if (has_acpi_companion(dev) && pp->idx == 0)
>> +                       pp->irq = platform_get_irq(to_platform_device(dev), 0);
>> +
> 
>>                 pp->irq_shared  = false;
>>                 pp->gpio_base   = -1;
> 
> 
>> +
>>                 if (dev->of_node)
>>                         pp->name = to_of_node(fwnode)->full_name;
> 
> This change doesn't belong the patch, though it should gone with the
> two lines of pp->name assignment as per Alan's suggestion to get rid
> of pp->name completely.

Agree, I plan to take Alan's suggestion, thank you.

> 
>> +
>> +               if (has_acpi_companion(dev))
>> +                       pp->name = acpi_dev_name(to_acpi_device_node(fwnode));
>