From: Daniel Bristot de Oliveira <bristot@redhat.com>
To: "Moore, Robert" <robert.moore@intel.com>,
"Zheng, Lv" <lv.zheng@intel.com>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
Len Brown <lenb@kernel.org>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"devel@acpica.org" <devel@acpica.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ACPICA: Remove unnecessary "\n" from an ACPI_INFO boot message
Date: Wed, 30 Mar 2016 22:11:29 -0300 [thread overview]
Message-ID: <56FC7941.2080202@redhat.com> (raw)
In-Reply-To: <94F2FBAB4432B54E8AACC7DFDE6C92E37E455538@ORSMSX110.amr.corp.intel.com>
On 03/29/2016 04:09 PM, Moore, Robert wrote:
> Actually, I did in fact put that there to break up the output after the tables are loaded. Is this a problem?
Well, I do not believe that there is a real problem on it.
On the other hand, it does not seem to be common to have blank lines in
the kernel log, and as there is no info about from where the black line
comes from, it does not even seems to be connected to the previous
message. So although my patch is about "cosmetics", IMHO it is worth as
pattern or best practices. Feel free to reject if it is not the case, np
:-).
-- Daniel
next prev parent reply other threads:[~2016-03-31 1:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-28 17:59 [PATCH] ACPICA: Remove unnecessary "\n" from an ACPI_INFO boot message Daniel Bristot de Oliveira
2016-03-29 19:09 ` Moore, Robert
2016-03-31 1:11 ` Daniel Bristot de Oliveira [this message]
2016-03-31 4:27 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FC7941.2080202@redhat.com \
--to=bristot@redhat.com \
--cc=devel@acpica.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox