From: Daniel Wagner <wagi@monom.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Tom Zanussi <tom.zanussi@linux.intel.com>,
rostedt@goodmis.org, masami.hiramatsu.pt@hitachi.com,
josh@joshtriplett.org, andi@firstfloor.org,
mathieu.desnoyers@efficios.com, peterz@infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v16 22/23] tracing: Add hist trigger 'log2' modifier
Date: Thu, 31 Mar 2016 07:09:07 +0200 [thread overview]
Message-ID: <56FCB0F3.4060908@monom.org> (raw)
In-Reply-To: <20160329151701.GA1797@danjae>
Hi Namhyung,
On 03/29/2016 05:17 PM, Namhyung Kim wrote:
> On Tue, Mar 29, 2016 at 12:01:40PM +0200, Daniel Wagner wrote:
>> cat /sys/kernel/debug/tracing/events/test/latency_complete/hist
>> # event histogram
>> #
>> # trigger info: hist:keys=latency.log2:vals=hitcount:sort=latency.log2:size=2048 [active]
>> #
>> #
>
> Maybe we want to skip printing those flags for sort keys..
> What about this?
Yes, something like this makes sense to me. As I said, it is only a
minor detail and maybe just not worth the extra code.
Anyway, the hist patches do really work nicely. I hope they get merged soon.
cheers,
daniel
next prev parent reply other threads:[~2016-03-31 5:09 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 18:54 [PATCH 00/23] tracing: 'hist' triggers Tom Zanussi
2016-03-03 18:54 ` [PATCH v16 01/23] tracing: Update some tracing_map constants and comments Tom Zanussi
2016-03-03 18:54 ` [PATCH v16 02/23] tracing: Add 'hist' event trigger command Tom Zanussi
2016-03-08 22:26 ` Steven Rostedt
2016-03-09 0:03 ` Tom Zanussi
2016-03-03 18:54 ` [PATCH v16 03/23] tracing: Add hist trigger support for multiple values ('vals=' param) Tom Zanussi
2016-03-03 18:54 ` [PATCH v16 04/23] tracing: Add hist trigger support for compound keys Tom Zanussi
2016-03-03 18:54 ` [PATCH v16 05/23] tracing: Add hist trigger support for user-defined sorting ('sort=' param) Tom Zanussi
2016-03-03 18:54 ` [PATCH v16 06/23] tracing: Add hist trigger support for pausing and continuing a trace Tom Zanussi
2016-03-03 18:54 ` [PATCH v16 07/23] tracing: Add hist trigger support for clearing " Tom Zanussi
2016-03-03 18:54 ` [PATCH v16 08/23] tracing: Add hist trigger 'hex' modifier for displaying numeric fields Tom Zanussi
2016-03-03 18:54 ` [PATCH v16 09/23] tracing: Add hist trigger 'sym' and 'sym-offset' modifiers Tom Zanussi
2016-03-03 18:54 ` [PATCH v16 10/23] tracing: Add hist trigger 'execname' modifier Tom Zanussi
2016-03-03 18:54 ` [PATCH v16 11/23] tracing: Add hist trigger 'syscall' modifier Tom Zanussi
2016-03-03 18:54 ` [PATCH v16 12/23] tracing: Add hist trigger support for stacktraces as keys Tom Zanussi
2016-03-03 18:54 ` [PATCH v16 13/23] tracing: Support string type key properly Tom Zanussi
2016-03-03 18:54 ` [PATCH v16 14/23] tracing: Remove restriction on string position in hist trigger keys Tom Zanussi
2016-03-03 18:54 ` [PATCH v16 15/23] tracing: Add enable_hist/disable_hist triggers Tom Zanussi
2016-03-03 18:54 ` [PATCH v16 16/23] tracing: Add 'hist' trigger Documentation Tom Zanussi
2016-03-03 18:54 ` [PATCH v16 17/23] tracing: Add support for multiple hist triggers per event Tom Zanussi
2016-03-03 18:54 ` [PATCH v16 18/23] tracing: Add support for named triggers Tom Zanussi
2016-03-03 18:54 ` [PATCH v16 19/23] tracing: Add support for named hist triggers Tom Zanussi
2016-03-03 18:55 ` [PATCH v16 20/23] kselftests/ftrace : Add event trigger testcases Tom Zanussi
2016-03-03 18:55 ` [PATCH v16 21/23] kselftests/ftrace: Add hist " Tom Zanussi
2016-03-03 18:55 ` [PATCH v16 22/23] tracing: Add hist trigger 'log2' modifier Tom Zanussi
2016-03-29 10:01 ` Daniel Wagner
2016-03-29 15:17 ` Namhyung Kim
2016-03-31 5:09 ` Daniel Wagner [this message]
2016-04-05 23:35 ` Tom Zanussi
2016-03-03 18:55 ` [PATCH v16 23/23] kselftests/ftrace: Add a test for log2 modifier of hist trigger Tom Zanussi
2016-03-09 14:44 ` [PATCH 00/23] tracing: 'hist' triggers Steven Rostedt
2016-03-09 15:04 ` Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FCB0F3.4060908@monom.org \
--to=wagi@monom.org \
--cc=andi@firstfloor.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).