From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755787AbcCaGhM (ORCPT ); Thu, 31 Mar 2016 02:37:12 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:42473 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752504AbcCaGhK (ORCPT ); Thu, 31 Mar 2016 02:37:10 -0400 X-AuditID: cbfee68f-f79c86d0000012ad-33-56fcc5936965 Message-id: <56FCC593.9020007@samsung.com> Date: Thu, 31 Mar 2016 15:37:07 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-version: 1.0 To: Shawn Lin , Ulf Hansson Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] Cleanup setup_clock callback from dw_mmc References: <1453944616-16224-1-git-send-email-shawn.lin@rock-chips.com> In-reply-to: <1453944616-16224-1-git-send-email-shawn.lin@rock-chips.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnkeLIzCtJLcpLzFFi42JZI2JSoDvl6J8wg6tvmCwu75rDZnHkfz+j xZ0n61ktjq8Nd2DxuHNtD5vH31n7WTw+b5ILYI7isklJzcksSy3St0vgyvg+T7ign6fizIw2 tgbGM5xdjJwcEgImEtcaPrND2GISF+6tZ+ti5OIQEljBKLH1+ztGmKIjpy+yQyRmMUp8v7YG ynnAKPF8XydYO6+AlsTxY9fBOlgEVCWOrT/ODGKzCehIbP92nAnEFhUIk3iwbi8rRL2gxI/J 91hAbBEBP4mtO7aygdjMAtYSP3+0gtUICzhKPJs4F8wWEvCQuN12CGw+p4CnxP+Fs4HqOYDq 9STuX9SCaJWX2LzmLTPIbRICq9gl5n6+CHWPgMS3yYdYQOolBGQlNh1ghnhMUuLgihssExjF ZiG5aBbC1FlIpi5gZF7FKJpakFxQnJReZKxXnJhbXJqXrpecn7uJERg/p/8969/BePeA9SFG AQ5GJR5ejbQ/YUKsiWXFlbmHGE2BjpjILCWanA+M0rySeENjMyMLUxNTYyNzSzMlcd6FUj+D hQTSE0tSs1NTC1KL4otKc1KLDzEycXBKNTAuPfvJXN5UaOvE+2fFCx9L75ndL7+y9NMWxZkn i9Ltzr8XPzqbkU9TaPG/RFH+uyZ966vO6RUf75jef++PWZZMuVv25TML//fopd61PRkz/dJx 9101Io3Rv881Wn37kXC3b8uJS6EKH77d3SQXWtNw3DVNdNekexurntmwK2RqzBPPrmqIvP5T iaU4I9FQi7moOBEAmhG05poCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCIsWRmVeSWpSXmKPExsVy+t9jQd3JR/+EGTR+s7K4vGsOm8WR//2M FneerGe1OL423IHF4861PWwef2ftZ/H4vEkugDmqgdEmIzUxJbVIITUvOT8lMy/dVsk7ON45 3tTMwFDX0NLCXEkhLzE31VbJxSdA1y0zB2ibkkJZYk4pUCggsbhYSd8O04TQEDddC5jGCF3f kCC4HiMDNJCwhjHj+zzhgn6eijMz2tgaGM9wdjFyckgImEgcOX2RHcIWk7hwbz1bFyMXh5DA LEaJ79fWsEM4Dxglnu/rBKviFdCSOH7sOiOIzSKgKnFs/XFmEJtNQEdi+7fjTCC2qECYxIN1 e1kh6gUlfky+xwJiiwj4SWzdsZUNxGYWsJb4+aMVrEZYwFHi2cS5YLaQgIfE7bZDYPM5BTwl /i+cDVTPAVSvJ3H/ohZEq7zE5jVvmScwAl2JsGEWQtUsJFULGJlXMUqkFiQXFCel5xrlpZbr FSfmFpfmpesl5+duYgTH6DPpHYyHd7kfYhTgYFTi4b2Q/CdMiDWxrLgy9xCjBAezkgivwBGg EG9KYmVValF+fFFpTmrxIUZTYBBMZJYSTc4Hpo+8knhDYxMzI0sjc0MLI2NzJXHex//XhQkJ pCeWpGanphakFsH0MXFwSjUw7smu0q9arrX7tF3oj+jXYsW1838/ZEmQfzDxu52KmOtRBkOf Ne8by1YIWp6odQ1x4b1c/mNR47Gm55P7pSKeT+te7OOooqf9M13YNHnt8fObkqcsmLPG3as/ wsrw0xnfy1f+cLqmOtc+DMp2rXOeYvxc7c3bMHb55x0KJ5quJn8w8qrQ+vlUiaU4I9FQi7mo OBEAN7xur+cCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shawn, On 01/28/2016 10:30 AM, Shawn Lin wrote: > Hello Jeahoon > > Currently dw_mmc is a little too queen-size. As we had cleanup > prepare_command callback some days before, there are also some > ones deserve to remove. Also we should avoid add new quirks or > callbacks into dw_mmc in order to avoid the dilemma sdhci meets > now. > > This patchset remove setup_clock callback. Obviously, adding a > callback just for one-time-used clk stuff makes no sense. We combine > what setup_clock does before into init callback. For exynos platfrom, > it needs call init hook after resume, so we add new argument in init > hook to indicate whether it needs do clk stuff or not. > I sent the patch "mmc: dw_mmc: exynos: add the function for controlling SMU" https://patchwork.kernel.org/patch/8707591/ Then it doesn't need this patch for adding setup_clk argument. "mmc: dw_mmc: add setup_clk for init hook" Could you resend the patch-set after applying my patch? Best Regards, Jaehoon Chung > > > Shawn Lin (4): > mmc: dw_mmc-rockchip: remove setup_clock for rockchip > mmc: dw_mmc: add setup_clk for init hook > mmc: dw_mmc-exynos: remove dw_mci_exynos_setup_clock > mmc: dw_mmc: remove setup_clock callback > > drivers/mmc/host/dw_mmc-exynos.c | 15 ++++----------- > drivers/mmc/host/dw_mmc-rockchip.c | 14 +++++--------- > drivers/mmc/host/dw_mmc.c | 11 +---------- > drivers/mmc/host/dw_mmc.h | 3 +-- > 4 files changed, 11 insertions(+), 32 deletions(-) >