From: "Matias Bjørling" <mb@lightnvm.io>
To: Wenwei Tao <ww.tao0320@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH 1/2] lightnvm: use rrpc->nr_luns to calculate the rrpc area size
Date: Thu, 31 Mar 2016 10:57:01 +0200 [thread overview]
Message-ID: <56FCE65D.8060901@lightnvm.io> (raw)
In-Reply-To: <CACygaLCJ9MCXRHh0D0RwQ4E61Q5X3Ymn0vE1O4Wx5mN5fy1_bQ@mail.gmail.com>
On 03/31/2016 10:31 AM, Wenwei Tao wrote:
> 2016-03-30 22:28 GMT+08:00 Wenwei Tao <ww.tao0320@gmail.com>:
>> rrpc->nr_sects is calculated after rrpc init luns succeeds,
>> before that the value of rrpc->nr_sects is zero, so we cannot
>> use it to calcuate rrpc area size, we use rrpc->nr_luns instead.
>>
>> Signed-off-by: Wenwei Tao <ww.tao0320@gmail.com>
>> ---
>> drivers/lightnvm/rrpc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/lightnvm/rrpc.c b/drivers/lightnvm/rrpc.c
>> index 3ab6495..516a045 100644
>> --- a/drivers/lightnvm/rrpc.c
>> +++ b/drivers/lightnvm/rrpc.c
>> @@ -1223,7 +1223,7 @@ static int rrpc_area_init(struct rrpc *rrpc, sector_t *begin)
>> {
>> struct nvm_dev *dev = rrpc->dev;
>> struct nvmm_type *mt = dev->mt;
>> - sector_t size = rrpc->nr_sects * dev->sec_size;
>> + sector_t size = dev->sec_size * dev->sec_per_lun * rrpc->nr_luns;
>
> dev->sec_size * dev->sec_per_lun * rrpc->nr_luns could be oveflow,
> should use (sector_t)dev->sec_size * dev->sec_per_lun * rrpc->nr_luns
> instead. Will submit another patch to fix it.
Hi Wenwei,
How about moving rrpc_area_init call under the rrpc_luns_init call
instead. Then nr_sects will have been initialized?
>>
>> size >>= 9;
>>
>> --
>> 2.7.2.333.g70bd996
>>
next prev parent reply other threads:[~2016-03-31 8:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 14:28 [PATCH 1/2] lightnvm: use rrpc->nr_luns to calculate the rrpc area size Wenwei Tao
2016-03-30 14:28 ` [PATCH 2/2] lightnvm: use relative logical address in rrpc_l2p_update Wenwei Tao
2016-03-31 9:11 ` Matias Bjørling
2016-03-31 11:09 ` Wenwei Tao
2016-03-31 8:31 ` [PATCH 1/2] lightnvm: use rrpc->nr_luns to calculate the rrpc area size Wenwei Tao
2016-03-31 8:57 ` Matias Bjørling [this message]
2016-03-31 9:51 ` Wenwei Tao
2016-03-31 10:07 ` Matias Bjørling
2016-03-31 10:26 ` Wenwei Tao
2016-03-31 13:25 ` Matias Bjørling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FCE65D.8060901@lightnvm.io \
--to=mb@lightnvm.io \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ww.tao0320@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox