From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756112AbcCaMLM (ORCPT ); Thu, 31 Mar 2016 08:11:12 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:44320 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750971AbcCaMLJ (ORCPT ); Thu, 31 Mar 2016 08:11:09 -0400 X-AuditID: cbfec7f4-f796c6d000001486-62-56fd13d990ae Subject: Re: [PATCH v7 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver To: Chanwoo Choi References: <1459415165-32613-1-git-send-email-cw00.choi@samsung.com> <1459415165-32613-2-git-send-email-cw00.choi@samsung.com> Cc: myungjoo.ham@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com, kgene@kernel.org, rjw@rjwysocki.net, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, linux.amoon@gmail.com, m.reichl@fivetechno.de, tjakobi@math.uni-bielefeld.de, inki.dae@samsung.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org From: Sylwester Nawrocki Message-id: <56FD13D2.1050300@samsung.com> Date: Thu, 31 Mar 2016 14:10:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: <1459415165-32613-2-git-send-email-cw00.choi@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrLIsWRmVeSWpSXmKPExsVy+t/xq7o3hf+GGax+p2Rx/ctzVov5R86x WvS/Wchqce7VSkaLSfcnsFi8fmFo0f/4NbPF2aY37BabHl9jtbi8aw6bxefeI4wWM87vY7JY t/EWu8Xty7wWL4/8YLRYev0ik8XtxhVsFhOmr2WxOHP6EqtF694j7BZtqz+wOoh6rJm3htGj pbmHzeNyXy+Tx6079R47Z91l91i5/Aubx6ZVnWwem5fUe/w7xu6x5Wo7i0ffllWMHp83yQXw RHHZpKTmZJalFunbJXBlHD7yl61gNkfF8/O7mRsYL7B1MXJySAiYSDxu3cwCYYtJXLi3Hiwu JLCUUWLiJq8uRi4g+zmjxMNHX5lBEsICsRLHJ0xiBLFFBDQkZv69wgjR0MgoseydHkgDs0A/ i8S8x9fAprIJGEr0Hu0DKuLg4BXQkpi53xMkzCKgKnFzQj9YiahAhMSTuSfB5vAKCEr8mHwP LM4p4Cbx7foNsFZmAT2J+xe1QMLMAvISm9e8ZZ7AKDALSccshKpZSKoWMDKvYhRNLU0uKE5K zzXUK07MLS7NS9dLzs/dxAiJ1C87GBcfszrEKMDBqMTDq5n2J0yINbGsuDL3EKMEB7OSCK+8 0N8wId6UxMqq1KL8+KLSnNTiQ4zSHCxK4rxzd70PERJITyxJzU5NLUgtgskycXBKNTBu/V28 qXZF+/Kpe6Q2e58oCL3HbZ/Ip2yizu5W9OzzqTfm1yuERbhigvrTXx1jmdnL3LRGOvGlbcQM +cWOF0u/r4m1tAlcIhi4s2h+sUns5BXHbz5Mk1jTekN761fv654vL2zMyebI6HF+cftbn4ZD ut4xsVvx2T8PxEy8y6AWEjVbNn/6AkslluKMREMt5qLiRAAlW81b0AIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/31/2016 11:05 AM, Chanwoo Choi wrote: > +static int exynos_bus_target(struct device *dev, unsigned long *freq, u32 flags) > +{ > + new_opp = devfreq_recommended_opp(dev, freq, flags); > + if (IS_ERR_OR_NULL(new_opp)) { > + dev_err(dev, "failed to get recommed opp instance\n"); s/recommed/recommended/ > + rcu_read_unlock(); > + return PTR_ERR(new_opp); > + } > +} > +static int exynos_bus_probe(struct platform_device *pdev) > +{ > + bus->devfreq = devm_devfreq_add_device(dev, profile, "simple_ondemand", > + ondemand_data); > + if (IS_ERR_OR_NULL(bus->devfreq)) { > + dev_err(dev, "failed to add devfreq device\n"); > + return PTR_ERR(bus->devfreq); > + } > +} You should use IS_ERR() instead of IS_ERR_OR_NULL(), since functions of which the return value is being tested return only ERR_PTR() values. IS_ERR_OR_NULL() suggest NULL values are possible and then constructs like if (IS_ERR_OR_NULL(result)) return PTR_ERR(result); are not correct anyway. -- Regards, Sylwester