From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756890AbcCaMyn (ORCPT <rfc822;w@1wt.eu>);
	Thu, 31 Mar 2016 08:54:43 -0400
Received: from mailout2.w1.samsung.com ([210.118.77.12]:26474 "EHLO
	mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756855AbcCaMyj (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 31 Mar 2016 08:54:39 -0400
X-AuditID: cbfec7f5-f792a6d000001302-01-56fd1e0c6cbb
Subject: Re: [PATCH v7 01/20] PM / devfreq: exynos: Add generic exynos bus
 frequency driver
To: cw00.choi@samsung.com
References: <1459415165-32613-1-git-send-email-cw00.choi@samsung.com>
 <1459415165-32613-2-git-send-email-cw00.choi@samsung.com>
 <56FD13D2.1050300@samsung.com>
 <CAGTfZH0mgxyQPKBTX=ZXgtSn=bQ2zAMSNMHfO+OXh3U5qrUr4g@mail.gmail.com>
Cc: "myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        =?UTF-8?Q?Krzysztof_Koz=c5=82owski?= <k.kozlowski@samsung.com>,
        Kukjin Kim <kgene@kernel.org>, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Russell King - ARM Linux <linux@arm.linux.org.uk>,
        Anand Moon <linux.amoon@gmail.com>,
        Markus Reichl <m.reichl@fivetechno.de>,
        Tobias Jakobi <tjakobi@math.uni-bielefeld.de>,
        "inki.dae@samsung.com" <inki.dae@samsung.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        devicetree <devicetree@vger.kernel.org>
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
Message-id: <56FD1E04.8050808@samsung.com>
Date: Thu, 31 Mar 2016 14:54:28 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-version: 1.0
In-reply-to: <CAGTfZH0mgxyQPKBTX=ZXgtSn=bQ2zAMSNMHfO+OXh3U5qrUr4g@mail.gmail.com>
Content-type: text/plain; charset=utf-8
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHIsWRmVeSWpSXmKPExsVy+t/xa7o8cn/DDHb957C4/uU5q8X8I+dY
	LfrfLGS1OPdqJaPFpPsTWCxevzC06H/8mtnibNMbdotNj6+xWlzeNYfN4nPvEUaLGef3MVms
	23iL3eL2ZV6Ll0d+MFosvX6RyeJ24wo2iwnT17JYnDl9idWide8Rdou21R9YHUQ91sxbw+jR
	0tzD5nG5r5fJ49adeo+ds+6ye6xc/oXNY9OqTjaPzUvqPf4dY/fYcrWdxaNvyypGj8+b5AJ4
	orhsUlJzMstSi/TtErgyFjZtZinYw1LRemwCcwPjDuYuRk4OCQETicWNb1ggbDGJC/fWs3Ux
	cnEICSxllDj6Yx87SEJI4DmjxMK/xiC2sECsxPEJkxi7GDk4RAQkJVr2mUHUv2SUWNQ3mwnE
	YRaYzy6x+tBxVpAGNgFDid6jfYwgNq+AlsT2y0fBbBYBVYmZLduZQGxRgQiJJ3NPQtUISvyY
	fA/sIk6BYIn7G7ezgSxjFlCXmDIlFyTMLCAvsXnNW+YJjAKzkHTMQqiahaRqASPzKkbR1NLk
	guKk9FwjveLE3OLSvHS95PzcTYyQWP26g3HpMatDjAIcjEo8vBeT/4QJsSaWFVfmHmKU4GBW
	EuHVl/0bJsSbklhZlVqUH19UmpNafIhRmoNFSZx35q73IUIC6YklqdmpqQWpRTBZJg5OqQbG
	tPJDuZyb/jPyHNhU4tZQ3cHZZuXGUVEmuKZvrgnzYs1ap+jr57e/vfGrrDB/5+NndncjPWaX
	fDv9/7WI4Ivt62/yiT7PiWW/sXwSNwub8LLgP2xBWVfPx4jEnv+adkb5RsFn5e9fXNKXRp9l
	f5cktLH8yqMlbavWF6+1mNO/qeJv18S5X9P0lViKMxINtZiLihMB/UuQktECAAA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03/31/2016 02:28 PM, Chanwoo Choi wrote:
>> > You should use IS_ERR() instead of IS_ERR_OR_NULL(), since functions
>> > of which the return value is being tested return only ERR_PTR() values.
>> > IS_ERR_OR_NULL() suggest NULL values are possible and then constructs
>> > like
>> >         if (IS_ERR_OR_NULL(result))
>> >                 return PTR_ERR(result);
>> >
>> > are not correct anyway.
>
> OK. I'll use IS_ERR() instead of IS_ERR_OR_NULL()

Thanks, I forgot to mention there is similar issue in patches
5/20 and 6/20.

--
Regards
Sylwester